Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Fix type issues with emitted events #4932

Merged
merged 8 commits into from
Jun 11, 2024
Merged

[core] Fix type issues with emitted events #4932

merged 8 commits into from
Jun 11, 2024

Conversation

davidkpiano
Copy link
Member

Fixes #4931

@davidkpiano davidkpiano linked an issue Jun 10, 2024 that may be closed by this pull request
Bug: type disagreement between emitted events and toPromise #4931
Closed
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jun 10, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 8061cc0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
xstate Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@davidkpiano davidkpiano mentioned this pull request Jun 10, 2024
Merged
boneskull
boneskull reviewed Jun 10, 2024
View reviewed changes
packages/core/src/createActor.ts Show resolved Hide resolved
packages/core/src/types.ts Show resolved Hide resolved
packages/xstate-solid/src/fromActorRef.ts Outdated Show resolved Hide resolved
davidkpiano and others added 2 commits June 10, 2024 15:02
@davidkpiano @boneskull
Update packages/xstate-solid/src/fromActorRef.ts
ca61b3f 
Co-authored-by: Christopher Hiller <boneskull@boneskull.com>
@davidkpiano
Fix type import
bb9ecf2
@davidkpiano
Copy link
Member Author

cc. @Andarist

davidkpiano and others added 3 commits June 11, 2024 06:55
@davidkpiano @Andarist
Update packages/core/test/emit.test.ts
cd89aed 
Co-authored-by: Mateusz Burzyński <mateuszburzynski@gmail.com>
@davidkpiano @Andarist
Update packages/core/src/actors/index.ts
7e60c60 
Co-authored-by: Mateusz Burzyński <mateuszburzynski@gmail.com>
@davidkpiano
Move test
f1ec68f
@davidkpiano davidkpiano merged commit 71a7f86 into main Jun 11, 2024
1 check passed
@davidkpiano davidkpiano deleted the davidkpiano/4931-bug-type-disagreement-between-emitted-events-and-topromise branch June 11, 2024 12:00
@github-actions github-actions bot mentioned this pull request Jun 11, 2024
Merged
@ZeroXClem ZeroXClem mentioned this pull request Aug 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boneskull boneskull boneskull left review comments

@Andarist Andarist Andarist approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: type disagreement between emitted events and toPromise
3 participants
@davidkpiano @boneskull @Andarist