[core] Tighten StateMachine types and fix issue #5008
#5009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3059beb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
davidkpiano
commented
Jul 31, 2024
davidkpiano
commented
Jul 31, 2024
| @@ -413,33 +413,33 @@ describe('state tests', () => { | |||
| }); | |||
|
|
|||
| it('should test with input', () => { | |||
| const model = createTestModel( | |||
There was a problem hiding this comment.
This was a little weird too... for some reason, TS complained if setup(…) was inside createTestModel(setup(…).createMachine(…)) but not if I moved it outside.
davidkpiano
commented
Jul 31, 2024
…n-type' of https://github.com/statelyai/xstate into davidkpiano/5008-bug-5170-property-machine-is-missing-in-type
davidkpiano
commented
Jul 31, 2024
Comment on lines
-69
to
+71
| TEmitted extends EventObject = EventObject, // TODO: remove default | ||
| TMeta extends MetaObject = MetaObject, | ||
| TConfig extends StateSchema = StateSchema | ||
| TEmitted extends EventObject, | ||
| TMeta extends MetaObject, | ||
| TConfig extends StateSchema |
There was a problem hiding this comment.
This is the main change. By having these as optional, we were (well, at least I was) miscounting the generic type params, and some were erroneously using their default types.
davidkpiano
deleted the
davidkpiano/5008-bug-5170-property-machine-is-missing-in-type
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The internal types for
StateMachine<...>have been improved so that all type params are required, to prevent errors when using the types. This fixes weird issues like #5008.