Support clojure 1.10.1 #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update clojure dependency to latest stable version 1.10.1 * Update :spec-provider.stats/distinct-values spec to conform to most recent spec function specs
|
Resolves #28. |
|
Merged, many thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
spec function specs
The
distinct-valuesspec was using(s/* any?)to validate what appears to always be a set. This commit changed thes/*function to validate that each spec passed is eithernil?orsequential?: clojure/spec.alpha@3b34bd3A set is not sequential so this was failing. On the assumption that
distinct-valuesis always a set, I've updated the spec to instead check for a set collection containing unique elements that all conform toany?.Let me know if you'd like me to change anything here. If the assumption that
distinct-valuesis always supposed to be a set is invalid, happy to update the spec accordingly.