list_issues_from_repo only valid request

src/git_portfolio/github_service.py

@@ -27,7 +27,7 @@ class AbstractGithubService(abc.ABC):
     def list_issues_from_repo(
         self,
         github_repo: str,
-        request: il.IssueListValidRequest | il.IssueListInvalidRequest,
+        request: il.IssueListValidRequest,
     ) -> list[i.Issue]:
         """Return list of issues from one repository."""
         raise NotImplementedError  # pragma: no cover
@@ -134,43 +134,39 @@ def create_issue_from_repo(self, github_repo: str, issue: i.Issue) -> str:
     def list_issues_from_repo(
         self,
         github_repo: str,
-        request: il.IssueListValidRequest | il.IssueListInvalidRequest,
+        request: il.IssueListValidRequest,
     ) -> list[i.Issue]:
         """Return list of issues from one repository."""
-        if isinstance(request, il.IssueListValidRequest):
-            repo = self._get_repo(github_repo)
-
-            domain_issues = []
-            if not request.filters:
-                issues = list(repo.issues())
-                for issue in issues:
-                    labels = {label.name for label in issue.labels()}
-                    domain_issues.append(
-                        i.Issue(issue.number, issue.title, issue.body, labels)
-                    )
-                return issues
-
-            obj = request.filters.get("obj__eq")
-            state = request.filters.get("state__eq")
-            title_query = request.filters.get("title__contains")
-            issues = list(repo.issues(state=state))
-
-            if obj == "issue":
-                issues = [issue for issue in issues if issue.pull_request_urls is None]
-            elif obj == "pull request":
-                issues = [issue for issue in issues if issue.pull_request_urls]
-
-            if title_query:
-                issues = [issue for issue in issues if title_query in issue.title]
+        repo = self._get_repo(github_repo)
 
+        domain_issues = []
+        if not request.filters:
+            issues = list(repo.issues())
             for issue in issues:
                 labels = {label.name for label in issue.labels()}
                 domain_issues.append(
                     i.Issue(issue.number, issue.title, issue.body, labels)
                 )
+            return issues
+
+        obj = request.filters.get("obj__eq")
+        state = request.filters.get("state__eq")
+        title_query = request.filters.get("title__contains")
+        issues = list(repo.issues(state=state))
+
+        if obj == "issue":
+            issues = [issue for issue in issues if issue.pull_request_urls is None]
+        elif obj == "pull request":
+            issues = [issue for issue in issues if issue.pull_request_urls]
+
+        if title_query:
+            issues = [issue for issue in issues if title_query in issue.title]
+
+        for issue in issues:
+            labels = {label.name for label in issue.labels()}
+            domain_issues.append(i.Issue(issue.number, issue.title, issue.body, labels))
 
-            return domain_issues
-        return []
+        return domain_issues
 
     def close_issues_from_repo(
         self, github_repo: str, domain_issues: list[i.Issue]

src/git_portfolio/use_cases/git.py

@@ -44,7 +44,7 @@ def execute(
                 if popen.returncode == 0:
                     if stdout:
                         stdout_str = stdout.decode("utf-8")
-                        output += f"{stdout_str}\n"
+                        output += f"{stdout_str}"
                     else:
                         output += f"{command} successful.\n"
                     responses.append(res.ResponseSuccess(output))

tests/test_github_service.py

@@ -379,18 +379,6 @@ def test_list_issues_from_repo_obj_filter(
         assert response[0].title == DOMAIN_ISSUES[3].title
 
 
-def test_list_issues_from_repo_invalid_request(
-    domain_gh_conn_settings: list[cs.GhConnectionSettings],
-    mock_github3_login: MockerFixture,
-) -> None:
-    """It returns empty result."""
-    response = gs.GithubService(domain_gh_conn_settings[0]).list_issues_from_repo(
-        REPO, il.IssueListInvalidRequest()
-    )
-
-    assert response == []
-
-
 def test_list_issues_from_repo_no_filter_request(
     mocker: MockerFixture,
     domain_gh_conn_settings: list[cs.GhConnectionSettings],

tests/use_cases/test_git.py

@@ -30,7 +30,7 @@ def test_execute_success(mock_popen: MockerFixture) -> None:
 
     assert len(responses) == 2
     assert isinstance(responses[0], res.ResponseSuccess)
-    assert responses[0].value == f"{REPO_NAME}: some output\n"
+    assert responses[0].value == f"{REPO_NAME}: some output"
 
 
 def test_execute_success_no_output(mock_popen: MockerFixture) -> None: