Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add api.github.com/repos/*/*/tarball to whitelist #5

Closed
wants to merge 1 commit into from

Conversation

vtjnash
Copy link
Contributor

@vtjnash vtjnash commented Apr 13, 2015

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@staticfloat
Copy link
Owner

In order to get proper naming, we need to get this line to trigger on the new URLs as well; so we need to check for both archive and tarball there.

@vtjnash
Copy link
Contributor Author

vtjnash commented Apr 15, 2015

i don't really have a way to experiment with this locally to test any changes there. it seems like https://github.com/vtjnash/cache.julialang.org/blob/0200742142e7d815a92bf8187974fe8c5ee0d19c/cache.py#L143 might need a corresponding change too then?

@staticfloat
Copy link
Owner

Nope, that should be fine. That's not a regex, it's actually just a string, so /github.com/ won't match /api.github.com/.

@staticfloat
Copy link
Owner

I will test for you to make sure things work as they should. You can, of course, just run it locally, but all the S3 uploading stuff won't work, which makes it difficult.

@tkelman
Copy link
Collaborator

tkelman commented May 16, 2015

Bump, Travis builds for base PR's fail pretty often due to Rmath-julia not getting downloaded correctly.

@staticfloat
Copy link
Owner

Merged in 312bbc5

@staticfloat
Copy link
Owner

Should be working now, thanks for the reminder.

@tkelman
Copy link
Collaborator

tkelman commented May 19, 2015

rmath-julia still seems really flaky? 2 pr's within the last couple hours had failures there

@staticfloat
Copy link
Owner

It turns out init.d scripts won't auto-restart for you if something goes haywire, (I confused them with upstart scripts) so I've added in an auto-restarter to bring the cache service back up if it goes down.

@staticfloat
Copy link
Owner

I believe that was the problem, btw. That the cache service was down when that test ran. I looked through the logs and found a suspicious "exception occurred while processing request" message at the end.

@tkelman
Copy link
Collaborator

tkelman commented May 19, 2015

i'm glad you understand this stuff, thanks for looking into it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants