St 356 cannot read properties of undefined reading chains #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mwmerz
commented
Mar 24, 2023
mwmerz
commented
- return function in loop if tokens.chain is empty
ericHgorski
added a commit
that referenced
this pull request
Mar 24, 2023
This reverts commit 7d4165c.
ericHgorski
added a commit
that referenced
this pull request
Mar 24, 2023
ericHgorski
added a commit
that referenced
this pull request
Mar 24, 2023
ericHgorski
added a commit
that referenced
this pull request
Mar 24, 2023
Jared-TFL
added a commit
that referenced
this pull request
Apr 25, 2023
* hard coded stakes alliance tokens to 100 dollars (#77) * Fix disconnection issue (#79) Co-authored-by: Alessandro Candeago <54709706+alecande11@users.noreply.github.com> * feat: loading optimizations (#80) * Feat/loading optimizations (#267) * fix: receive page bug on desktop * wip: network optimization * wip: network optimization 2 * wip: optimize InitChains comp * wip: optimize InitNetworks comp 2 * wip: optimize InitNetworks comp 3 * wip: optimize InitNetworks comp 4 * cleanup * fix: loading bug * fix: loading bug 2 * cleanup * Fix network validation requests * Add page loader during validation --------- Co-authored-by: Alessandro Candeago <54709706+alecande11@users.noreply.github.com> * Fix disconnection issue (#76) --------- Co-authored-by: Alessandro Candeago <54709706+alecande11@users.noreply.github.com> * feat: show disabled after networks query (#81) * v7.1.2 (#78) * hard coded stakes alliance tokens to 100 dollars (#77) * Fix disconnection issue (#79) Co-authored-by: Alessandro Candeago <54709706+alecande11@users.noreply.github.com> * feat: loading optimizations (#80) * Feat/loading optimizations (#267) * fix: receive page bug on desktop * wip: network optimization * wip: network optimization 2 * wip: optimize InitChains comp * wip: optimize InitNetworks comp 2 * wip: optimize InitNetworks comp 3 * wip: optimize InitNetworks comp 4 * cleanup * fix: loading bug * fix: loading bug 2 * cleanup * Fix network validation requests * Add page loader during validation --------- Co-authored-by: Alessandro Candeago <54709706+alecande11@users.noreply.github.com> * Fix disconnection issue (#76) --------- Co-authored-by: Alessandro Candeago <54709706+alecande11@users.noreply.github.com> --------- Co-authored-by: Joshua Brigati <joshua.brigati@gmail.com> Co-authored-by: Alessandro Candeago <54709706+alecande11@users.noreply.github.com> * feat: show disabled networks only after loading finishes --------- Co-authored-by: Joshua Brigati <joshua.brigati@gmail.com> Co-authored-by: Alessandro Candeago <54709706+alecande11@users.noreply.github.com> * cleanup extension (#83) * feat: send tx on enter press (#84) * feat: send tx on enter press * fix: null check endsWith on extension startup * Update ProposalHeader.tsx * v7.1.3 * feat: receive page updates (#89) * ST-293 fix token filter logic to not exclude assets without prices (#87) * fix: guard against undefined (#90) * fix: create sig bug (#92) * trigger event on network and wallet change (#93) * St 323 fix classic finder links (#94) * fix: create sig bug * fix: classic finder link * 7.1.5 * Expose public key request (#97) * Pubkey request * Fix publick key implementation * Fix confirm button width * Fix pubkey storage on first time import * fix: add decimal places from denom (#98) * 7.1.6 * fix: guard against token.chains being empty (#101) * Revert "fix: guard against token.chains being empty (#101)" (#103) This reverts commit 7d4165c. * Revert "Revert "fix: guard against token.chains being empty (#101)" (#103)" This reverts commit dc81f5d. * 7.1.7 * fix: guard against token being empty in InitBankBalance (#106) * fix: switch overflow-y to scroll (#104) * feat: replace terra.kitchen/utils with terra-money/terra-utils (#100) * St 332 suggest network (#105) * Pubkey request * Fix publick key implementation * Fix confirm button width * Suggest network UI * Settings for custom chains * Cleanup test env * cleanup * fix scrolling * fix card scrolling * add custom sign mode on sign and post * St 347 kado multichain fiat integration (#111) * feat: extension kado fiat ramp * fix vesting error * fix classic contract execution (#115) * Fix ICS20 out of gas error (#350) * ST-392: show origin name and favicon in the ConfirmTx page (#121) * fix confirm tx origin * fix check for relative/absolute favicon url --------- Co-authored-by: Joshua Brigati <joshua.brigati@gmail.com> Co-authored-by: plubber <51789398+ericHgorski@users.noreply.github.com> Co-authored-by: Alessandro Candeago <54709706+alecande11@users.noreply.github.com> Co-authored-by: plubber <er.h.gorski@gmail.com> Co-authored-by: Mike <17463738+mwmerz@users.noreply.github.com> Co-authored-by: evilpeach <kanisorn.peach@gmail.com>
alecande11
added a commit
that referenced
this pull request
May 3, 2023
* hard coded stakes alliance tokens to 100 dollars (#77) * Fix disconnection issue (#79) Co-authored-by: Alessandro Candeago <54709706+alecande11@users.noreply.github.com> * feat: loading optimizations (#80) * Feat/loading optimizations (#267) * fix: receive page bug on desktop * wip: network optimization * wip: network optimization 2 * wip: optimize InitChains comp * wip: optimize InitNetworks comp 2 * wip: optimize InitNetworks comp 3 * wip: optimize InitNetworks comp 4 * cleanup * fix: loading bug * fix: loading bug 2 * cleanup * Fix network validation requests * Add page loader during validation --------- Co-authored-by: Alessandro Candeago <54709706+alecande11@users.noreply.github.com> * Fix disconnection issue (#76) --------- Co-authored-by: Alessandro Candeago <54709706+alecande11@users.noreply.github.com> * feat: show disabled after networks query (#81) * v7.1.2 (#78) * hard coded stakes alliance tokens to 100 dollars (#77) * Fix disconnection issue (#79) Co-authored-by: Alessandro Candeago <54709706+alecande11@users.noreply.github.com> * feat: loading optimizations (#80) * Feat/loading optimizations (#267) * fix: receive page bug on desktop * wip: network optimization * wip: network optimization 2 * wip: optimize InitChains comp * wip: optimize InitNetworks comp 2 * wip: optimize InitNetworks comp 3 * wip: optimize InitNetworks comp 4 * cleanup * fix: loading bug * fix: loading bug 2 * cleanup * Fix network validation requests * Add page loader during validation --------- Co-authored-by: Alessandro Candeago <54709706+alecande11@users.noreply.github.com> * Fix disconnection issue (#76) --------- Co-authored-by: Alessandro Candeago <54709706+alecande11@users.noreply.github.com> --------- Co-authored-by: Joshua Brigati <joshua.brigati@gmail.com> Co-authored-by: Alessandro Candeago <54709706+alecande11@users.noreply.github.com> * feat: show disabled networks only after loading finishes --------- Co-authored-by: Joshua Brigati <joshua.brigati@gmail.com> Co-authored-by: Alessandro Candeago <54709706+alecande11@users.noreply.github.com> * cleanup extension (#83) * feat: send tx on enter press (#84) * feat: send tx on enter press * fix: null check endsWith on extension startup * Update ProposalHeader.tsx * v7.1.3 * feat: receive page updates (#89) * ST-293 fix token filter logic to not exclude assets without prices (#87) * fix: guard against undefined (#90) * fix: create sig bug (#92) * trigger event on network and wallet change (#93) * St 323 fix classic finder links (#94) * fix: create sig bug * fix: classic finder link * 7.1.5 * Expose public key request (#97) * Pubkey request * Fix publick key implementation * Fix confirm button width * Fix pubkey storage on first time import * fix: add decimal places from denom (#98) * 7.1.6 * fix: guard against token.chains being empty (#101) * Revert "fix: guard against token.chains being empty (#101)" (#103) This reverts commit 7d4165c. * Revert "Revert "fix: guard against token.chains being empty (#101)" (#103)" This reverts commit dc81f5d. * 7.1.7 * fix: guard against token being empty in InitBankBalance (#106) * fix: switch overflow-y to scroll (#104) * feat: replace terra.kitchen/utils with terra-money/terra-utils (#100) * St 332 suggest network (#105) * Pubkey request * Fix publick key implementation * Fix confirm button width * Suggest network UI * Settings for custom chains * Cleanup test env * cleanup * fix scrolling * fix card scrolling * add custom sign mode on sign and post * St 347 kado multichain fiat integration (#111) * feat: extension kado fiat ramp * fix vesting error * fix classic contract execution (#115) * Fix ICS20 out of gas error (#350) * ST-392: show origin name and favicon in the ConfirmTx page (#121) * fix confirm tx origin * fix check for relative/absolute favicon url * fix: guard for empty network + chainID (#127) * chore: bump extension versions (#128) * update featherjs * fix: buy button network (#126) Only display buy button on live networks: mainnet & classic * fix: allow wallet sbumission on confirm password entered first (#118) * Update feather.js and log-finder-ruleset (#131) * 7.2.3 (#129) (#133) * fix: guard for empty network + chainID (#127) * chore: bump extension versions (#128) --------- Co-authored-by: plubber <51789398+ericHgorski@users.noreply.github.com> Co-authored-by: Mike <17463738+mwmerz@users.noreply.github.com> --------- Co-authored-by: Joshua Brigati <joshua.brigati@gmail.com> Co-authored-by: plubber <51789398+ericHgorski@users.noreply.github.com> Co-authored-by: plubber <er.h.gorski@gmail.com> Co-authored-by: Mike <17463738+mwmerz@users.noreply.github.com> Co-authored-by: evilpeach <kanisorn.peach@gmail.com> Co-authored-by: Michael Merz <mwmerz@protonmail.com> Co-authored-by: Manuel Alessandro Collazo <collazo.manuel6@gmail.com>
Jared-TFL
pushed a commit
that referenced
this pull request
May 9, 2023
* hard coded stakes alliance tokens to 100 dollars (#77) * Fix disconnection issue (#79) Co-authored-by: Alessandro Candeago <54709706+alecande11@users.noreply.github.com> * feat: loading optimizations (#80) * Feat/loading optimizations (#267) * fix: receive page bug on desktop * wip: network optimization * wip: network optimization 2 * wip: optimize InitChains comp * wip: optimize InitNetworks comp 2 * wip: optimize InitNetworks comp 3 * wip: optimize InitNetworks comp 4 * cleanup * fix: loading bug * fix: loading bug 2 * cleanup * Fix network validation requests * Add page loader during validation --------- Co-authored-by: Alessandro Candeago <54709706+alecande11@users.noreply.github.com> * Fix disconnection issue (#76) --------- Co-authored-by: Alessandro Candeago <54709706+alecande11@users.noreply.github.com> * feat: show disabled after networks query (#81) * v7.1.2 (#78) * hard coded stakes alliance tokens to 100 dollars (#77) * Fix disconnection issue (#79) Co-authored-by: Alessandro Candeago <54709706+alecande11@users.noreply.github.com> * feat: loading optimizations (#80) * Feat/loading optimizations (#267) * fix: receive page bug on desktop * wip: network optimization * wip: network optimization 2 * wip: optimize InitChains comp * wip: optimize InitNetworks comp 2 * wip: optimize InitNetworks comp 3 * wip: optimize InitNetworks comp 4 * cleanup * fix: loading bug * fix: loading bug 2 * cleanup * Fix network validation requests * Add page loader during validation --------- Co-authored-by: Alessandro Candeago <54709706+alecande11@users.noreply.github.com> * Fix disconnection issue (#76) --------- Co-authored-by: Alessandro Candeago <54709706+alecande11@users.noreply.github.com> --------- Co-authored-by: Joshua Brigati <joshua.brigati@gmail.com> Co-authored-by: Alessandro Candeago <54709706+alecande11@users.noreply.github.com> * feat: show disabled networks only after loading finishes --------- Co-authored-by: Joshua Brigati <joshua.brigati@gmail.com> Co-authored-by: Alessandro Candeago <54709706+alecande11@users.noreply.github.com> * cleanup extension (#83) * feat: send tx on enter press (#84) * feat: send tx on enter press * fix: null check endsWith on extension startup * Update ProposalHeader.tsx * v7.1.3 * feat: receive page updates (#89) * ST-293 fix token filter logic to not exclude assets without prices (#87) * fix: guard against undefined (#90) * fix: create sig bug (#92) * trigger event on network and wallet change (#93) * St 323 fix classic finder links (#94) * fix: create sig bug * fix: classic finder link * 7.1.5 * Expose public key request (#97) * Pubkey request * Fix publick key implementation * Fix confirm button width * Fix pubkey storage on first time import * fix: add decimal places from denom (#98) * 7.1.6 * fix: guard against token.chains being empty (#101) * Revert "fix: guard against token.chains being empty (#101)" (#103) This reverts commit 7d4165c. * Revert "Revert "fix: guard against token.chains being empty (#101)" (#103)" This reverts commit dc81f5d. * 7.1.7 * fix: guard against token being empty in InitBankBalance (#106) * fix: switch overflow-y to scroll (#104) * feat: replace terra.kitchen/utils with terra-money/terra-utils (#100) * St 332 suggest network (#105) * Pubkey request * Fix publick key implementation * Fix confirm button width * Suggest network UI * Settings for custom chains * Cleanup test env * cleanup * fix scrolling * fix card scrolling * add custom sign mode on sign and post * St 347 kado multichain fiat integration (#111) * feat: extension kado fiat ramp * fix vesting error * fix classic contract execution (#115) * Fix ICS20 out of gas error (#350) * ST-392: show origin name and favicon in the ConfirmTx page (#121) * fix confirm tx origin * fix check for relative/absolute favicon url * fix: guard for empty network + chainID (#127) * chore: bump extension versions (#128) * update featherjs * Show if a wallet is a ledger on connection * remove ts-expect-error --------- Co-authored-by: Joshua Brigati <joshua.brigati@gmail.com> Co-authored-by: plubber <51789398+ericHgorski@users.noreply.github.com> Co-authored-by: plubber <er.h.gorski@gmail.com> Co-authored-by: Mike <17463738+mwmerz@users.noreply.github.com> Co-authored-by: evilpeach <kanisorn.peach@gmail.com> Co-authored-by: Michael Merz <mwmerz@protonmail.com>
alecande11
deleted the
ST-356-cannot-read-properties-of-undefined-reading-chains
branch
mwmerz
pushed a commit
that referenced
this pull request
Feb 16, 2024
fix: decimal limit in send amount input
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.