St 307 add guard clause to common x is undefined cases #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
1d8324d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://08c932b1.station-1a1.pages.dev |
| Branch Preview URL: | https://st-307-add-guard-clause-to-c.station-1a1.pages.dev |
ericHgorski
deleted the
ST-307-add-guard-clause-to-common-x-is-undefined-cases
branch
Jared-TFL
pushed a commit
that referenced
this pull request
Feb 28, 2023
* fix: receive page bug on desktop (#264) * Feat/loading optimizations (#267) * fix: receive page bug on desktop * wip: network optimization * wip: network optimization 2 * wip: optimize InitChains comp * wip: optimize InitNetworks comp 2 * wip: optimize InitNetworks comp 3 * wip: optimize InitNetworks comp 4 * cleanup * fix: loading bug * fix: loading bug 2 * cleanup * Fix network validation requests * Add page loader during validation --------- Co-authored-by: Alessandro Candeago <54709706+alecande11@users.noreply.github.com> * hard coded stakes alliance tokens to 100 dollars (#269) * feat: show disabled networks only after loading finishes (#275) * ST-289 reset form (#280) * feat: form resets on desktop after successful tx * feat: submit send tx on enter key press * cleanup * St 286 donut graph fixes (#278) * Made graph data switch from using value on individual chains to use amount to fix displaying 'NaN' when we dont have native token price. And changed display of '0% to '<1%' - ST-286 * fixed a lot of bug on the staking info cards. Made amounts show up on Delegations and Undelegations cards and other fixes - ST-286 * ST-293 fix token filter logic to not exclude assets without prices (#284) * Fix lock function (#286) * ST-248 improve addresses display/access in Connected component (#285) * feat: receive page QR code * feat: routing and component setup * feat: address display changes on desktop * feat: view address ledger button * feat: style cleanup * fix: bug to disconnect ledger * St 307 add guard clause to common x is undefined cases (#287) * fix: type error * fix: guard close for prefix property --------- Co-authored-by: Alessandro Candeago <54709706+alecande11@users.noreply.github.com> Co-authored-by: Joshua Brigati <brigati.joshua@gmail.com>
Jared-TFL
pushed a commit
that referenced
this pull request
Mar 7, 2023
* fix: receive page bug on desktop (#264) * Feat/loading optimizations (#267) * fix: receive page bug on desktop * wip: network optimization * wip: network optimization 2 * wip: optimize InitChains comp * wip: optimize InitNetworks comp 2 * wip: optimize InitNetworks comp 3 * wip: optimize InitNetworks comp 4 * cleanup * fix: loading bug * fix: loading bug 2 * cleanup * Fix network validation requests * Add page loader during validation --------- Co-authored-by: Alessandro Candeago <54709706+alecande11@users.noreply.github.com> * hard coded stakes alliance tokens to 100 dollars (#269) * feat: show disabled networks only after loading finishes (#275) * ST-289 reset form (#280) * feat: form resets on desktop after successful tx * feat: submit send tx on enter key press * cleanup * St 286 donut graph fixes (#278) * Made graph data switch from using value on individual chains to use amount to fix displaying 'NaN' when we dont have native token price. And changed display of '0% to '<1%' - ST-286 * fixed a lot of bug on the staking info cards. Made amounts show up on Delegations and Undelegations cards and other fixes - ST-286 * ST-293 fix token filter logic to not exclude assets without prices (#284) * Fix lock function (#286) * ST-248 improve addresses display/access in Connected component (#285) * feat: receive page QR code * feat: routing and component setup * feat: address display changes on desktop * feat: view address ledger button * feat: style cleanup * fix: bug to disconnect ledger * St 307 add guard clause to common x is undefined cases (#287) * fix: type error * fix: guard close for prefix property * fix: classic finder link (#293) * fix: create sig bug (#289) * feat: update tfm api url (#296) * Changed Send title and back arrow to be absolute so content will scroll under it on smaller heights. Changed Receive page to have scroll on chain table with a max height (#292) --------- Co-authored-by: Alessandro Candeago <54709706+alecande11@users.noreply.github.com> Co-authored-by: Joshua Brigati <brigati.joshua@gmail.com> Co-authored-by: Mike <17463738+mwmerz@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.