-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: FinderLink chainID #366
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with Cloudflare Pages
|
chainID not properly passed into FinderLink causing validator to not be displayed on parsed messages.
terran6
force-pushed
the
fix/validator-history-display
branch
from
May 3, 2023 09:13
3c2bca6
to
c7445af
Compare
Remove @ts-expect-error lines that are unneeded. Causing warnings when starting application.
This reverts commit 0afc3c2.
alecande11
approved these changes
May 3, 2023
alecande11
added a commit
that referenced
this pull request
May 4, 2023
* St 353 display chain selection on inactive chain click in OtherChainButtons (#329) * WIP: chains display prefs open * feat: open preferences on click * cleanup * cleanup * feat: swap terra.kitchen/utils for @terra-money/terra-utils (#321) * feat: guard against empty networks, chaindID, or lcd (#327) * feat: kado integration and updated wallet buttons (#320) * feat: kado integration and updated wallet buttons * Fix passing/not passing * fix prettier * fix z-index for LatestTx popup * fix chain filter (#344) * fix: val name on stake withdraw (#349) * fix: val name on stake withdraw * cleanup * feat: add empty condition if no staking rewards * cleanup * Fix ICS20 out of gas error (#350) * ST-390: show undelegations if nothing is staked (#351) * show undelegations if nothing is staked * fix: no rewards message conditional Do not display "None on selected chain" message under staking rewards while network is loading. * fix: translate alert message --------- Co-authored-by: Manuel Alessandro Collazo <collazo.manuel6@gmail.com> * ST-391: fix chain filer bug when switching between mainnet, testnet and classic (#352) * fix chain filter * if "all" is not an option select terra * fix ICS gasAdjustment (#358) * fix: naming (#357) * update wallet-provider (#363) * add bank balance to swap tx invalidated queries (#362) * Increase gas adjustment for all IBC transactions (#361) * fix: empty additional chains (#360) * fix: FinderLink chainID (#366) * fix: validator history display chainID not properly passed into FinderLink causing validator to not be displayed on parsed messages. * fix: remove unneeded ts-expect-error Remove @ts-expect-error lines that are unneeded. Causing warnings when starting application. * Revert "fix: remove unneeded ts-expect-error" This reverts commit 0afc3c2. * ST-382 integrate Alliance (#365) * restyle tables and quickstake page * Open quickstake form inside a modal * query data from the alliance module * Alliance QuickStake * fix query when no address connected * fix coin selector, disable alliance stake for ledger * show warning for ledger * disable asset filter * Fix alliance undelegate * Filter LSD with their native token * manual stake table design * Cleanup * Alliance manual staking * Fix maunal stake UI * fix staking details * Show validator icon on delegations page * show max button even when balance is 0 * Include alliance assets in the stake chart * Add alliance fees info box * Show all available staking assets * hide non-whitelisted rewards * fic chain filter * cleanup * Show chain name inside a pill * fix merge conflicts * Fix alliance UI (#369) * fix alliance ui * Show info box only on delegate * fix cf build error * Fix alliance UI pt.2 (#370) * fix alliance ui * Show info box only on delegate * fix cf build error * add whale to tfm swap * Update tooltips on staking table * cleanup * feat: enable osmo support for kado (#368) --------- Co-authored-by: plubber <51789398+ericHgorski@users.noreply.github.com> Co-authored-by: Mike <17463738+mwmerz@users.noreply.github.com> Co-authored-by: plubber <er.h.gorski@gmail.com> Co-authored-by: Manuel Alessandro Collazo <collazo.manuel6@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The chainID is not properly passed into FinderLink causing validator and terra address links not to be displayed on parsed messages.
NOTE: "0stake" result for delegation reward being reworked on Alliance.
Before
After