Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move build steps, so that a build does not deploy to prod before failing #3130

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 16 additions & 16 deletions .github/workflows/deploy_to_prod.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,22 +19,6 @@ jobs:
uses: enonic/release-tools/build-and-publish@master
with:
skipPublishing: true
- id: deploy_app_to_XP
uses: 'enonic/action-app-deploy@main'
with:
url: ${{ secrets.ENONIC_PROD_URL }}
username: ${{ secrets.ENONIC_USER }}
password: ${{ secrets.ENONIC_PROD_PASS }}
client_cert: ${{ secrets.ENONIC_CERT }}
client_key: ${{ secrets.ENONIC_KEY }}
app_jar: "./build/libs/*.jar"
- name: Upload artifacts
id: upload_artifacts
if: success()
uses: actions/upload-artifact@v4
with:
name: mimir-prod-${{ github.run_number }}
path: "./build/libs/*.jar"
- name: Get Version Number
id: get_version_number
run: |
Expand All @@ -45,6 +29,22 @@ jobs:
run: gh release create $VERSION --generate-notes
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: Upload artifacts
id: upload_artifacts
if: success()
uses: actions/upload-artifact@v4
with:
name: mimir-prod-${{ github.run_number }}
path: "./build/libs/*.jar"
- id: deploy_app_to_XP
uses: 'enonic/action-app-deploy@main'
with:
url: ${{ secrets.ENONIC_PROD_URL }}
username: ${{ secrets.ENONIC_USER }}
password: ${{ secrets.ENONIC_PROD_PASS }}
client_cert: ${{ secrets.ENONIC_CERT }}
client_key: ${{ secrets.ENONIC_KEY }}
app_jar: "./build/libs/*.jar"
- name: Send success message to Slack
id: slack_success
if: success()
Expand Down
Loading