rbindlist use.names=FALSE for data.table v1.12.4 #5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I've just submitted v1.12.2 to CRAN. There will be no impact to
tatoo
. But there is one change which will affect you in the next release v1.12.4. Of the 621 packages on CRAN using data.table,tatoo
is the only one affected by this. It's because your tests are so good and strict that they are detecting the new message when your test checks there should be no message. I turned off the message for automatic names (V[0-9]+
) sotatoo
wouldn't fail on CRAN.Some of your rbindlist calls have a data.frame-like item with
V1,V2,V3,...
column names. These names don't match the column names of the items beingrbind
-ed, hence the new message.I've checked that with this PR,
tatoo
will pass v1.12.4.Please see data.table news item 5 in v1.12.2 here: https://github.com/Rdatatable/data.table/blob/master/NEWS.md
Hope this change is ok to make.
Best, Matt