Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rbindlist use.names=FALSE for data.table v1.12.4 #5

Merged
merged 1 commit into from
Mar 29, 2019
Merged

rbindlist use.names=FALSE for data.table v1.12.4 #5

merged 1 commit into from
Mar 29, 2019

Conversation

mattdowle
Copy link
Contributor

Hi,
I've just submitted v1.12.2 to CRAN. There will be no impact to tatoo. But there is one change which will affect you in the next release v1.12.4. Of the 621 packages on CRAN using data.table, tatoo is the only one affected by this. It's because your tests are so good and strict that they are detecting the new message when your test checks there should be no message. I turned off the message for automatic names (V[0-9]+) so tatoo wouldn't fail on CRAN.
Some of your rbindlist calls have a data.frame-like item with V1,V2,V3,... column names. These names don't match the column names of the items being rbind-ed, hence the new message.
I've checked that with this PR, tatoo will pass v1.12.4.
Please see data.table news item 5 in v1.12.2 here: https://github.com/Rdatatable/data.table/blob/master/NEWS.md
Hope this change is ok to make.
Best, Matt

@s-fleck
Copy link
Collaborator

s-fleck commented Mar 29, 2019

Thanks for the great work on data.table!
I'll try to get a new version on CRAN asap/over the weekend.

@s-fleck s-fleck merged commit 8260961 into statistikat:master Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants