StatsigServer.shutdown: Don't join threads that were never started #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In `StatsigServer`, when `local_mode` is set to `True` the `__background_download_config` and `__background_download_idlists` are never set in `initialize`, so we should not call `join` on those attributes in `shutdown`.
|
Nice catch! Looks like this does not apply to the other background threads in the logger, so this should be the scope of the fix. Will merge and publish v0.5.2 |
|
There was a small fix to this, but that was merged and we published v0.5.2. Thanks for your contribution! https://github.com/statsig-io/python-sdk/releases/tag/v0.5.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
StatsigServer, whenlocal_modeis set toTruethe__background_download_configand__background_download_idlistsare never set ininitialize, so we should not calljoinon those attributes inshutdown.