-
Notifications
You must be signed in to change notification settings - Fork 6
Make Rust SDK build to WebAssembly for Fastly Compute #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ments [Stable] (#1740) * Bot: Updated File Cargo.toml * Bot: Version synchronized in 18 files --------- Co-authored-by: statsig-kong[bot] <statsig-kong[bot]@users.noreply.github.com>
…741) * Bot: Updated File Cargo.toml * Bot: Version synchronized in 18 files --------- Co-authored-by: statsig-kong[bot] <statsig-kong[bot]@users.noreply.github.com>
* Bot: Updated File Cargo.toml * Bot: Version synchronized in 18 files --------- Co-authored-by: statsig-kong[bot] <statsig-kong[bot]@users.noreply.github.com>
[auto][cherrypick] c132a1b chore: add env variables (#1742)
…] (#1745) * Bot: Updated File Cargo.toml * Bot: Version synchronized in 18 files --------- Co-authored-by: statsig-kong[bot] <statsig-kong[bot]@users.noreply.github.com>
…le] (#1747) * Bot: Updated File Cargo.toml * Bot: Version synchronized in 18 files --------- Co-authored-by: statsig-kong[bot] <statsig-kong[bot]@users.noreply.github.com>
[auto][cherrypick] 8b27a60 chore: add comments into java (#1749)
…le] (#1751) * Bot: Updated File Cargo.toml * Bot: Version synchronized in 18 files --------- Co-authored-by: statsig-kong[bot] <statsig-kong[bot]@users.noreply.github.com>
* Bot: Updated File Cargo.toml * Bot: Version synchronized in 18 files --------- Co-authored-by: statsig-kong[bot] <statsig-kong[bot]@users.noreply.github.com>
…js core SDK (#1790) [auto][cherrypick] 0b22710 feat(node): Add OutputLogger interface for Node.js core SDK (#1724)
[auto][cherrypick] acf380c fix(node): generate file (#1793)
* Use more specific version of rustler, and set runtime: false as the docs suggest Signed-off-by: Chris Dosé <chris.dose@whatnot.com> * Apply `mix format` Signed-off-by: Chris Dosé <chris.dose@whatnot.com> * Add a basic elixir formatting check Signed-off-by: Chris Dosé <chris.dose@whatnot.com> --------- Signed-off-by: Chris Dosé <chris.dose@whatnot.com> Co-authored-by: Chris Dosé <chris.dose@whatnot.com>
|
Thanks for the PR @pishposh, I have merged it internally and it should got out with the next release. I'll leave the issue open until the release is public |
|
Thanks again @daniel-statsig! |
9bf20ed to
825d99f
Compare
|
Closing this issue as this was published in 0.9.0-rc.1 as 37a22ad |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Statsig gang, this PR gates a few pieces of
statsig-rustbehind compiler directives for Wasm:With these changes, I managed to get a Rust project using this crate to build to
wasm32-wasip1for deployment to Fastly Compute.Notes
For LocalFileEventLoggingAdapter, I ended up gating the whole thing, but I guess another option for Wasm would be to just skip file locking. Apparently WASIp1 has no notion of it, and the
file-guarddep refuses to compile to Wasm, while the new file-locking methods in Rust’s stdlib (1.89+) fail at runtime.reqwestdoesn’t build to wasm, but we need to use a custom network provider for Fastly Compute anyway. Here’s how we’ve configured Statsig in our app’s Cargo.toml:Also app-side, it seemed necessary to annotate
main()with#[tokio::main(flavor = "current_thread")]to get exposure events properly queued and sent.I’m new to Rust, so please let me know if there’s better ways of doing these things!