Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(topic): docker-compose.yml.j2: update the usage of 'topic' parameter #10

Merged
merged 1 commit into from
May 30, 2023

Conversation

Ivansete-status
Copy link
Contributor

Summary

Specifying the pubsub topics to the wakunode app through the topic parameter instead of the topics parameter.

More context

This change is interesting due to the deprecation of the 'topics' parameter, which was done in the next PR:
waku-org/nwaku#1727

This change is interesting due to the deprecation of the 'topics'
parameter.

waku-org/nwaku#1727
@jm-clius jm-clius requested a review from jakubgs May 30, 2023 11:23
Copy link
Member

@jakubgs jakubgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, do we need to coordinate deployment with version upgrade or is it fine to roll this out whenever?

Also, why are you using a fork? You should have permissions to push to this repo.

@Ivansete-status
Copy link
Contributor Author

Hi @jakubgs ,

I got the next error when trying to push the changes:
image

We can roll this out now because the changes are deployed.
cc - @jm-clius

@jakubgs
Copy link
Member

jakubgs commented May 30, 2023

Oh, because you're not in the nim team.

@jakubgs
Copy link
Member

jakubgs commented May 30, 2023

Appears to work fine on wakuv2.test:

admin@node-01.gc-us-central1-a.wakuv2.test:~ % grep '\--topic=' /docker/nim-waku-v2/docker-compose.yml
      --topic='/waku/2/default-waku/proto'
      --topic='/waku/2/dev-waku/proto'
admin@node-01.gc-us-central1-a.wakuv2.test:~ % d
CONTAINER ID   NAMES         IMAGE                                    CREATED         STATUS
7f35b77c5a94   nim-waku-v2   statusteam/nim-waku:deploy-wakuv2-test   4 minutes ago   Up 4 minutes (healthy)

@jakubgs
Copy link
Member

jakubgs commented May 30, 2023

Deployed to wakuv2.prod without issues as well.

@jakubgs jakubgs merged commit eed1a10 into status-im:master May 30, 2023
jakubgs added a commit to status-im/infra-nim-waku that referenced this pull request May 30, 2023
status-im/infra-role-nim-waku#10

Signed-off-by: Jakub Sokołowski <jakub@status.im>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants