Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added shard peer manager config flag #10

Closed

Conversation

SionoiS
Copy link
Contributor

@SionoiS SionoiS commented Jan 30, 2024

Hello! @apentori or @jakubgs

In order for us to extensively test my new relay peer manager this new flag is required.

Thanks!

@apentori
Copy link
Contributor

The varaible nim_waku_relay_shard_manager is not present in the role https://github.com/status-im/infra-role-nim-waku/. Therefore adding this variable wont activate your flag.
Can you specify the fleg so i can add it ?

@SionoiS
Copy link
Contributor Author

SionoiS commented Jan 31, 2024

The varaible nim_waku_relay_shard_manager is not present in the role https://github.com/status-im/infra-role-nim-waku/. Therefore adding this variable wont activate your flag. Can you specify the fleg so i can add it ?

Ah! I always forget it needs to be updated in 2 repo. The flag is --shard-relay-manager Thanks! @apentori

@apentori
Copy link
Contributor

apentori commented Feb 1, 2024

Flag added optionnaly in role status-im/infra-role-nim-waku@9c228ce

@apentori
Copy link
Contributor

apentori commented Feb 1, 2024

Pushed in f34e1e9

@apentori apentori closed this Feb 1, 2024
@jakubgs
Copy link
Member

jakubgs commented Feb 13, 2024

Are you guys sure this flag works?

jakubgs@node-01.do-ams3.waku.test:~ % tail -n2 /var/log/docker/nim-waku/docker.log
2024-02-13T21:17:07.675424+00:00 docker/nim-waku[380950]: Unrecognized option 'shard-relay-manager'#033[0m
2024-02-13T21:17:07.676511+00:00 docker/nim-waku[380950]: Try #033[36mwakunode2 --help#033[0m for more informati

Or did you forget to update the image to support it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants