Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update requirements to avoid using rest-private parameter #26

Merged
merged 1 commit into from
Sep 19, 2024
Merged

update requirements to avoid using rest-private parameter #26

merged 1 commit into from
Sep 19, 2024

Conversation

Ivansete-status
Copy link
Contributor

@Ivansete-status Ivansete-status commented Sep 19, 2024 •
edited
Loading

@Ivansete-status Ivansete-status mentioned this pull request Sep 19, 2024
Merged
@Ivansete-status Ivansete-status self-assigned this Sep 19, 2024
gabrielmer
gabrielmer approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@gabrielmer gabrielmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Ivansete-status @apentori
requirements: bump nim-waku role to remove rest-private parameter
8196f8b 
Signed-off-by: Ivan Folgueira Bande <ivansete@status.im>
@apentori apentori merged commit 8196f8b into master Sep 19, 2024
2 checks passed
@apentori apentori deleted the rm-unused-setting branch September 19, 2024 17:56
@apentori
Copy link
Contributor

Applied to both fleet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apentori apentori apentori approved these changes

@gabrielmer gabrielmer gabrielmer approved these changes

@jakubgs jakubgs jakubgs approved these changes

Assignees

@Ivansete-status Ivansete-status

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Ivansete-status @apentori @jakubgs @gabrielmer