Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Might connect to more than allowed number of connections. #108

Open
kdeme opened this issue Oct 21, 2019 · 1 comment
Open

Might connect to more than allowed number of connections. #108

kdeme opened this issue Oct 21, 2019 · 1 comment
Labels
P2P question Further information is requested

Comments

@kdeme
Copy link
Contributor

kdeme commented Oct 21, 2019

Currently the check of whether to try to connect to more peers happens before the call which tries to connect to an x amount of peers.
A seq of candidate nodes is returned by discovery and then connected to in parallel. This might result in a higher amount of peers. I guess this is also why it is called minPeers, so technically, there is no problem.

However, there might be use cases where you do not want to go over a maximum defined limit.
@kdeme kdeme added question Further information is requested P2P labels Oct 21, 2019
@kdeme
Copy link
Contributor Author

kdeme commented Oct 21, 2019

This is linked to #107 but not as severe as the own node is in control

This was referenced Oct 21, 2019
Open
Closed
@kdeme kdeme mentioned this issue Sep 20, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P2P question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kdeme