Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement waku/0 - current Status whisper fork as is #123

Closed
kdeme opened this issue Nov 18, 2019 · 4 comments
Closed

Implement waku/0 - current Status whisper fork as is #123

kdeme opened this issue Nov 18, 2019 · 4 comments
Assignees
Labels
Waku Issues related to Waku Swarm

Comments

@kdeme
Copy link
Contributor

kdeme commented Nov 18, 2019

Implement waku/0 protocol, a Status fork of Whisper implementing the additions/changes done to it.

This will mostly be adding message packets ids, changes to light client (not sure?), notification on send (how does this work now? and why?). Questions should be asked regarding the validity of changes (is everything still used and needed?).

Mailserver related changes are targeted in separate issue: https://github.com/status-im/nim-eth/issues/102

Requirements:

Acceptance: Implement Status go compatible waku/0.

@oskarth
Copy link
Contributor

oskarth commented Dec 5, 2019

@kdeme what's left / most prio in this? Hard to see at a glance what's missing

@oskarth
Copy link
Contributor

oskarth commented Dec 11, 2019

Mailserver client WIP PR for easier reference #141

@kdeme
Copy link
Contributor Author

kdeme commented Dec 13, 2019

What is left I think is:

  • Light client allowed to send through regular messages packet
  • Message confirmations part, although that part makes actually only sense for mail client / server communications.
  • Perhaps any of those other added (and not fully explained) protocol packets. But I think all relate to mail client / server implementations and are probably not even necessary.

@kdeme
Copy link
Contributor Author

kdeme commented Dec 20, 2019

This is mostly done now.

What is missing is mail server, but that has a separate issue. And confirmations are not implemented, as they are directly linked to mail server (only used there). The setting at Status packet is added however to be compatible.

Compatibility however will probably not be OK for now as there is also the Waku Mode PoC that is already added: see #124

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Waku Issues related to Waku Swarm
Projects
None yet
Development

No branches or pull requests

2 participants