discv4: Fix assert on invalid RLP list in Neighbours message #763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The assert would occur when the rlp size of the a node in the nodes rlp list is incorrectly set too high and then the next `listElem` call for the next node will start from the incorrect data. When that data is not a list the assert in `listElem` will be triggered. Fixed by adding a `listLen` call which checks if it is a list. Added also more strictness by: - Checking if that list is of len 4, which it must be - raising immediatly on invalid IP length - raising immediatly on invalid public key / node id + test cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The assert would occur when the rlp size of the a node in the nodes rlp list is incorrectly set too high and then the next
listElemcall for the next node will start from the incorrect data. When that data is not a list the assert inlistElemwill be triggered.Fixed by adding a
listLencall which checks if it is a list. Added also more strictness by: