Skip to content

Commit

Permalink
extend automatic serialization support for distinct in Nim 2 (#93)
Browse files Browse the repository at this point in the history
In Nim 2, `distinct` values no longer match `value is object` but need
to be checked separately with `value is distinct`. The underlying type
can be unwrapped with `distinctBase` to inspect whether this is a value
of type `distinct object` or `distinct` something-else.
  • Loading branch information
etan-status authored Jul 3, 2024
1 parent 9cf79c0 commit 89f7be1
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions json_serialization/writer.nim
Original file line number Diff line number Diff line change
Expand Up @@ -353,7 +353,7 @@ proc writeValue*(w: var JsonWriter, value: auto) {.gcsafe, raises: [IOError].} =
elif value is (seq or array or openArray):
w.writeArray(value)

elif value is (object or tuple):
elif value is (distinct or object or tuple):
mixin flavorUsesAutomaticObjectSerialization

type Flavor = JsonWriter.Flavor
Expand All @@ -364,7 +364,10 @@ proc writeValue*(w: var JsonWriter, value: auto) {.gcsafe, raises: [IOError].} =
const typeName = typetraits.name(type value)
{.error: "Please override writeValue for the " & typeName & " type (or import the module where the override is provided)".}

writeRecordValue(w, value)
when value is distinct:
writeRecordValue(w, distinctBase(value, recursive = false))
else:
writeRecordValue(w, value)
else:
const typeName = typetraits.name(value.type)
{.fatal: "Failed to convert to JSON an unsupported type: " & typeName.}
Expand Down

0 comments on commit 89f7be1

Please sign in to comment.