Basic support for Json flavours without default object serialization #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Other changes: * Migrate many procs accepting JsonReader to JsonLexer in order to reduce the number of generic instantiations and the resulting code bloat
arnetheduck
reviewed
Dec 19, 2023
|
|
||
| template createJsonFlavor*(FlavorName: untyped, | ||
| mimeTypeValue = "application/json", | ||
| automaticObjectSerialization = false, |
There was a problem hiding this comment.
this should probably be true since json is typically used for interop via standards - the way to get there would be to have a deprecated overload that has the old behavior
There was a problem hiding this comment.
I don't understand the remark. The false value here means that you'll get the explicit override behavior by default.
There was a problem hiding this comment.
ah oops, I read it wrong. 👍
|
nice, finally! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other changes: