feat: introduce Nim impl of generateAlias #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ It took a little more adjusting than setting some env vars, but it's done! |
michaelsbradleyjr
force-pushed
the
feat/nim-generatealias
branch
8 times, most recently
from
e4ef049 to
10ed8a5
Compare
michaelsbradleyjr
force-pushed
the
feat/nim-generatealias
branch
from
10ed8a5 to
8fdb979
Compare
michaelsbradleyjr
force-pushed
the
feat/nim-generatealias
branch
from
8fdb979 to
09a6b1e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #32
This PR depends on #41 and on a commit in a PR branch in status-go, so it's labeled don't merge yet for the time being.
It's also important to note that because of this PR's introduction of
nim-secp256k1as a dependency invendor/it's necessary to switch from building/linking status-go as a static library to building/linking as a shared library.