Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump nim-web3 to enable calling getPayload with exact type #4748

Merged
merged 1 commit into from
Mar 20, 2023
Merged

Conversation

tersec
Copy link
Contributor

@tersec tersec commented Mar 18, 2023

This allows nimbus-eth2 to avoid post-hoc validation when it knows entirely

Follow-up to #4465 (comment) #4465 (comment) #4465 (comment)

There are workarounds currently, e.g.,

when payloadFork == ConsensusFork.Capella:
# TODO: The engine_api module may offer an alternative API where it is guaranteed
# to return the correct response type (i.e. the rule below will be enforced
# during deserialization).
if req.read.executionPayload.withdrawals.isNone:
warn "Execution client did not return any withdrawals for a post-Shanghai block",
url = m.elConnections[idx].engineUrl.url
continue

But migrating nimbus-eth2 to the new API from nim-web3 can avoid these.

@github-actions
Copy link

Unit Test Results

         9 files  ±0    1 068 suites  ±0   30m 10s ⏱️ - 2m 31s
  3 648 tests ±0    3 369 ✔️ ±0  279 💤 ±0  0 ±0 
15 569 runs  ±0  15 264 ✔️ ±0  305 💤 ±0  0 ±0 

Results for commit 79788a1. ± Comparison against base commit 6539928.

@tersec tersec merged commit 2215798 into unstable Mar 20, 2023
@tersec tersec deleted the 0PO branch March 20, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant