fall back to non-fcu fork choice on epoch boundaries #5195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etan-status
approved these changes
Jul 17, 2023
| let | ||
| nextWallSlot = wallSlot + 1 | ||
| (validatorIndex, nextProposer) = self.checkNextProposer(wallSlot).valueOr: | ||
| return | ||
| return false |
There was a problem hiding this comment.
? self.checkNextProposer(wallSlot), if going with Opt[void]
There was a problem hiding this comment.
Yeah, will update these to be consistent
There was a problem hiding this comment.
also, Future[Opt[void]], accidentally forgot the Future wrapper on first attempt
There was a problem hiding this comment.
I did try ? self.checkNextProposer and it didn't seem to work, but can investigate later. The valueOr approach still works.
Co-authored-by: Etan Kissling <etan@status.im>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.