-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
block pull requests to stable
#6001
Conversation
Pull requests should be opened against the `unstable` branch. See https://nimbus.guide/contribute.html#build-and-deploy
Most recent instance: #6000 |
meh, or we can just retarget them as was done with 6000 instead of being obnoxious about it |
The CI is not re-run on base change / it may show as green on stable, but actually fail after merge. We can keep it pending until the next one that doesn't cleanly retarget :-) They happen from time to time. |
Yeah, it's always a gamble with retargeting, because it's either: a) ask them to do it on their own, which is the human version of "obnoxious" here; That one was a documentation fix so it was low-risk but typically for anything vaguely nontrivial I ask the person filing the PR to do it because of the risk of (c). In favor of this. |
One edge case here is Dependabot, which uses These are 100% of the time in the Nimbus codebase trivial changes, because thye're in Python dependencies, and just version bumps in |
There is an option to specify the target branch for Dependabot, but it is documented to be ignored for security patches: https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#target-branch Therefore, have updated the action to not trigger on Dependabot triggered PRs. |
Pull requests should be opened against the
unstable
branch. See https://nimbus.guide/contribute.html#build-and-deploy