fix /eth/v1/beacon/deposit_snapshot for EIP-4881
#6038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the `/eth/v1/beacon/deposit_snapshot` API to produce proper EIP-4881 compatible `DepositTreeSnapshot` responses. The endpoint used to expose a Nimbus-specific database internal format. Also fix trusted node sync to consume properly formatted EIP-4881 data with `--with-deposit-snapshot`, and `--finalized-deposit-tree-snapshot` beacon node launch option to use the EIP-4881 data. Further ensure that `ncli_testnet` produces EIP-4881 formatted data for interoperability.
Closed
|
There is still an off-by-1 somewhere, i.e., nimbus reports a slightly older snapshot than https://checkpoint-sync.holesky.ethpandaops.io, but at least the format is fixed now. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the
/eth/v1/beacon/deposit_snapshotAPI to produce proper EIP-4881 compatibleDepositTreeSnapshotresponses. The endpoint used to expose a Nimbus-specific database internal format.Also fix trusted node sync to consume properly formatted EIP-4881 data with
--with-deposit-snapshot, and--finalized-deposit-tree-snapshotbeacon node launch option to use the EIP-4881 data. Further ensure thatncli_testnetproduces EIP-4881 formatted data for interoperability.