Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure that rarely ran files are compiled on PR #6379

Merged
merged 7 commits into from
Jun 23, 2024

Conversation

etan-status
Copy link
Contributor

Add some missing files to isMainModule developer internal builds CI.

Add some missing files to `isMainModule` developer internal builds CI.
Copy link

github-actions bot commented Jun 21, 2024

Unit Test Results

         9 files  ±0    1 328 suites  ±0   32m 45s ⏱️ -25s
  4 998 tests ±0    4 650 ✔️ ±0  348 💤 ±0  0 ±0 
20 850 runs  ±0  20 446 ✔️ ±0  404 💤 ±0  0 ±0 

Results for commit 3d72a9e. ± Comparison against base commit 31653d5.

♻️ This comment has been updated with latest results.

@tersec
Copy link
Contributor

tersec commented Jun 22, 2024

The CI job it's using for this mostly isn't bottlenecked currently, but a couple of general possibilities:

  • use LOG_LEVEL=TRACE to catch potential regressions there which only pop up in the isMainModule code paths
  • don't require C compiler to codegen or link in CI when binaries won't be tested/used #5669 shows a way to approximately halve build times for code where running the result isn't important, as in these cases, by effectively disabling the C compiler's codegen. It might or might not be worthwhile, depending on targeted compilers. It works for both gcc and clang though, which should be enough on all targeted platforms. The trickiness there, which didn't end up being high enough priority to pursue, resulted from how the build system worked for that part of the CI system. But these raw nim c commands should be amenable to using -fsyntax-only fairly easily. The key flags are -fsyntax-only for the C compiler and --noLinking:on for Nim (because it can't link something which hasn't generated any code)

@tersec tersec merged commit e4efe9e into unstable Jun 23, 2024
15 checks passed
@tersec tersec deleted the dev/etan/ci-metadatadl branch June 23, 2024 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants