[WIP] epbs (eip-7732) #6443

Tomi-3-0 · 2024-07-23T12:11:48Z

No description provided.

beacon_chain/spec/datatypes/constants.nim

beacon_chain/spec/presets/mainnet/epbs_preset.nim

beacon_chain/spec/presets/minimal/epbs_preset.nim

github-actions · 2024-07-27T20:46:58Z

Unit Test Results

0 files -         9 0 suites - 1 355 0s ⏱️ - 38m 26s
0 tests -   5 218 0 ✔️ -   4 870 0 💤 - 348 0 ❌ ±0
0 runs - 21 738 0 ✔️ - 21 334 0 💤 - 404 0 ❌ ±0

Results for commit af91e67. ± Comparison against base commit ab4574e.

♻️ This comment has been updated with latest results.

beacon_chain/spec/datatypes/epbs.nim

beacon_chain/spec/ptc_status.nim

beacon_chain/spec/payload_attestations.nim

beacon_chain/spec/helpers.nim

tersec · 2024-08-06T05:09:08Z

beacon_chain/spec/payload_attestations.nim

+proc is_valid_indexed_payload_attestation(
+    state: capella.BeaconState, # [TODO] to be replaced with epbs.BeaconState
+    indexed_payload_attestation: IndexedPayloadAttestation): bool =
+  # Check if ``indexed_payload_attestation`` is not empty, has sorted and unique indices, and has a valid aggregate signature.


https://status-im.github.io/nim-style-guide/formatting.style.html

We strive to follow NEP-1 for style matters - naming, capitalization, 80-character limit etc.

This comment line is quite a bit longer than 80 characters.

This doesn't mean split (break) all the URLs, etc, or other things which for intrinsic reasons just must have longer than 80 character lines, but where it's feasible/practical to wrap at 80, that's the goal.

I forgot to call nimpretty on them. Thank you

Regarding nimpretty, see https://status-im.github.io/nim-style-guide/formatting.style.html#practical-notes

We do not use nimpretty - as of writing (Nim 1.6), it is not stable enough for daily use:

Can break working code

Naive formatting algorithm

if it works for you, that's great, but it has many flaws, so shouldn't be trusted too much, and shouldn't be used to reformat existing Nimbus code.

beacon_chain/spec/helpers.nim

beacon_chain/spec/payload_attestations.nim

beacon_chain/spec/helpers.nim

tersec · 2024-08-06T12:46:35Z

Merge branch 'status-im:stable' into epbs

the development branches should generally track unstable, not stable

Tomi-3-0 · 2024-08-06T13:05:57Z

Merge branch 'status-im:stable' into epbs

the development branches should generally track unstable, not stable

tracks unstable from my end:
...wants to merge 22 commits into status-im:unstable from Tomi-3-0:epbs

beacon_chain/spec/payload_attestations.nim

tersec · 2024-08-07T14:51:31Z

beacon_chain/spec/payload_attestations.nim

+      indexed_payload_attestation.signature)
+
+# # https://github.com/ethereum/consensus-specs/blob/1508f51b80df5488a515bfedf486f98435200e02/specs/_features/eipxxxx/beacon-chain.md#is_parent_block_full


is the # # https://... intentional?

beacon_chain/spec/payload_attestations.nim

tersec · 2024-08-11T03:21:11Z

Are the deletions of NimYAML, gnosis-chain-configs, nim-libbacktrace, nim-libp2p, and sepolia vendored git subrepositories intentional?

beacon_chain/spec/payload_attestations.nim

Redidacove · 2024-10-06T19:09:32Z

beacon_chain/spec/payload_attestations.nim

+    next_epoch = get_current_epoch(state) + 1
+  doAssert epoch <= next_epoch
+
+  for slot in start_slot .. start_slot + SLOTS_PER_EPOCH - 1:


Suggested change

for slot in start_slot .. start_slot + SLOTS_PER_EPOCH - 1:

for slot in start_slot .. <end_slot:

Isn't it better to take a variable like end_slot = start_slot + SLOTS_PER_EPOCH:
that would be more readable ib.

Does this give any performance advantage? I don't think so

beacon_chain/spec/datatypes/epbs.nim

tersec · 2024-10-08T03:31:09Z

2024-10-08T03:19:48.2521970Z /github-runner/workspace/nimbus-eth2/nimbus-eth2/beacon_chain/spec/datatypes/electra.nim(306, 3) Error: redefinition of 'ExecutionRequests'; previous declaration here: /github-runner/workspace/nimbus-eth2/nimbus-eth2/beacon_chain/spec/datatypes/electra.nim(193, 3)

Co-authored-by: Md Amaan <114795592+Redidacove@users.noreply.github.com>

Redidacove · 2024-10-08T10:00:59Z

2024-10-08T03:19:48.2521970Z /github-runner/workspace/nimbus-eth2/nimbus-eth2/beacon_chain/spec/datatypes/electra.nim(306, 3) Error: redefinition of 'ExecutionRequests'; previous declaration here: /github-runner/workspace/nimbus-eth2/nimbus-eth2/beacon_chain/spec/datatypes/electra.nim(193, 3)

Done removed👍

Execution Requests redefinition removed

tersec · 2024-10-08T12:55:43Z

2024-10-08T12:12:55.6224986Z /github-runner/workspace/nimbus-eth2/nimbus-eth2/beacon_chain/spec/datatypes/epbs.nim(37, 23) Error: undeclared identifier: 'PendingBalanceDeposit'
2024-10-08T12:12:55.6458434Z make: *** [Makefile:447: wss_sim] Error 1
--
2024-10-08T12:12:56.6417447Z /github-runner/workspace/nimbus-eth2/nimbus-eth2/beacon_chain/spec/datatypes/epbs.nim(37, 23) Error: undeclared identifier: 'PendingBalanceDeposit'
2024-10-08T12:12:56.6684431Z make: *** [Makefile:447: ncli_db] Error 1
--
2024-10-08T12:12:57.2701357Z /github-runner/workspace/nimbus-eth2/nimbus-eth2/beacon_chain/spec/datatypes/epbs.nim(37, 23) Error: undeclared identifier: 'PendingBalanceDeposit'
2024-10-08T12:12:57.2781920Z make: *** [Makefile:447: deposit_contract] Error 1
2024-10-08T12:12:57.3029205Z make: *** [Makefile:447: ncli] Error 1
--
2024-10-08T12:12:58.3929001Z /github-runner/workspace/nimbus-eth2/nimbus-eth2/beacon_chain/spec/datatypes/epbs.nim(37, 23) Error: undeclared identifier: 'PendingBalanceDeposit'
2024-10-08T12:12:58.4317242Z make: *** [Makefile:447: nimbus_validator_client] Error 1
2024-10-08T12:12:58.6439010Z /github-runner/workspace/nimbus-eth2/nimbus-eth2/beacon_chain/spec/datatypes/epbs.nim(37, 23) Error: undeclared identifier: 'PendingBalanceDeposit'
2024-10-08T12:12:58.6893775Z make: *** [Makefile:447: mev_mock] Error 1
--
2024-10-08T12:13:03.5207018Z /github-runner/workspace/nimbus-eth2/nimbus-eth2/beacon_chain/spec/datatypes/epbs.nim(37, 23) Error: undeclared identifier: 'PendingBalanceDeposit'
2024-10-08T12:13:03.5736294Z make: *** [Makefile:447: nimbus_light_client] Error 1

https://github.com/ethereum/consensus-specs/releases/tag/v1.5.0-alpha.7 contains ethereum/consensus-specs#3818 which replaces PendingBalanceDeposit with PendingDeposit

tersec · 2024-10-09T00:33:59Z

Haven't checked in detail yet, but something went awry with that merge. Some conflicts that I don't think were there before:

Redidacove · 2024-10-09T03:24:15Z

Strange there are conflicts in vendor packages.

tersec · 2024-10-09T04:23:40Z

Strange there are conflicts in vendor packages.

They aren't conflicts in the vendor packages as such, but different versions of the packages specified somehow in the git repository history so that the merge process can't automatically complete.

Specifically, the PRs:

Ordered trie for trie root computations #6610 accounts for the changes in nim-eth and nim-stew; and
discv5: bump to minilru #6611 accounts for the change in nim-unittest2

tersec · 2024-10-14T17:12:23Z

The files:

the binary executable tests/consensus_spec/bellatrix/test_fixture_operations (the one without the .nim extension);
the binary executable tests/consensus_spec/electra/test_fixture_operations (ditto, the one without the .nim extension)
the binary executable beacon_chain/spec/helpers (also, the one without the .nim extension); and
ubmodule update --init --recursive (as in, there's a file literally named ubmodule update --init --recursive in this branch)

should not be part of the git repository.

tersec · 2024-10-14T17:13:56Z

.vscode/tasks.json

Why was this file deleted?

Why was this file deleted?

I used github codespaces, might have been deleted in Codespaces due to automatic environment configuration.

tersec · 2024-10-14T17:52:01Z

Current build failure (locally reproducible via make all_tests):

/github-runner/workspace/nimbus-eth2/nimbus-eth2/tests/test_helpers.nim(276, 33) Error: type mismatch
Expression: remove_flag(flag, flag_index)
  [1] flag: uint8
  [2] flag_index: int

Expected one of (first mismatch at [position]):
[2] func remove_flag(flags: ParticipationFlags; flag_index: TimelyFlag): ParticipationFlags

Tomi-3-0 · 2024-10-14T18:48:56Z

Current build failure (locally reproducible via make all_tests):

/github-runner/workspace/nimbus-eth2/nimbus-eth2/tests/test_helpers.nim(276, 33) Error: type mismatch
Expression: remove_flag(flag, flag_index)
  [1] flag: uint8
  [2] flag_index: int

Expected one of (first mismatch at [position]):
[2] func remove_flag(flags: ParticipationFlags; flag_index: TimelyFlag): ParticipationFlags

:'(

tersec · 2024-10-16T09:25:18Z

/github-runner/workspace/nimbus-eth2/nimbus-eth2/vendor/nim-unittest2/unittest2.nim: In function ‘_ZN23test_message_signatures20runTestX60gensym450_E6string6string’:
/github-runner/workspace/nimbus-eth2/nimbus-eth2/vendor/nim-unittest2/unittest2.nim:1101:15: error: stack usage might be 5658432 bytes [-Werror=stack-usage=]
 1101 |   proc runTest(suiteName, testName: string): TestStatus {.raises: [], gensym.} =
      |               ^
/github-runner/workspace/nimbus-eth2/nimbus-eth2/vendor/nim-unittest2/unittest2.nim: In function ‘_ZN23test_message_signatures20runTestX60gensym509_E6string6string’:
/github-runner/workspace/nimbus-eth2/nimbus-eth2/vendor/nim-unittest2/unittest2.nim:1101:15: error: stack usage might be 5658944 bytes [-Werror=stack-usage=]
/github-runner/workspace/nimbus-eth2/nimbus-eth2/vendor/nim-unittest2/unittest2.nim: In function ‘_ZN23test_message_signatures20runTestX60gensym568_E6string6string’:
/github-runner/workspace/nimbus-eth2/nimbus-eth2/vendor/nim-unittest2/unittest2.nim:1101:15: error: stack usage might be 5658352 bytes [-Werror=stack-usage=]
lto1: some warnings being treated as errors
make[2]: *** [/tmp/cckbluCt.mk:263: /tmp/ccXwZhhR.ltrans87.ltrans.o] Error 1
make[2]: *** Waiting for unfinished jobs....
lto-wrapper: fatal error: make returned 2 exit status
compilation terminated.
/usr/bin/ld: error: lto-wrapper failed
collect2: error: ld returned 1 exit status
make[1]: *** [nimcache/release/all_tests/all_tests.makefile:3752: build] Error 1

The CI checks that maximum per-function static stack usage is 1MB:

nimbus-eth2/.github/workflows/ci.yml

Lines 129 to 138 in ec0accf

    
                     # Stack usage test and UBSAN on recent enough gcc: 
        
                     if [[ '${{ runner.os }}' == 'Linux' && '${{ matrix.target.cpu }}' == 'amd64' ]]; then 
        
                       if [[ '${{ github.sha }}' =~ ^7 ]]; then 
        
                         export WITH_UBSAN=1 
        
                         echo "WITH_UBSAN=1" >> $GITHUB_ENV 
        
                         export NIMFLAGS="${NIMFLAGS} -d:limitStackUsage --passC:-fsanitize=undefined --passL:-fsanitize=undefined" 
        
                       else 
        
                         export NIMFLAGS="${NIMFLAGS} -d:limitStackUsage" 
        
                       fi 
        
                     fi

Tomi-3-0 changed the title ~~Initial dummy commit~~ epbs (eip-7732) implementation Jul 23, 2024

Tomi-3-0 changed the title ~~epbs (eip-7732) implementation~~ [WIP] epbs (eip-7732) implementation Jul 27, 2024

Tomi-3-0 changed the title ~~[WIP] epbs (eip-7732) implementation~~ [WIP] epbs (eip-7732) Jul 27, 2024

tersec reviewed Jul 27, 2024

View reviewed changes

beacon_chain/spec/datatypes/constants.nim Outdated Show resolved Hide resolved

tersec reviewed Jul 27, 2024

View reviewed changes

beacon_chain/spec/presets/mainnet/epbs_preset.nim Outdated Show resolved Hide resolved

tersec reviewed Jul 27, 2024

View reviewed changes

beacon_chain/spec/presets/minimal/epbs_preset.nim Outdated Show resolved Hide resolved

tersec reviewed Aug 2, 2024

View reviewed changes

beacon_chain/spec/datatypes/epbs.nim Outdated Show resolved Hide resolved

tersec reviewed Aug 3, 2024

View reviewed changes

beacon_chain/spec/ptc_status.nim Outdated Show resolved Hide resolved

tersec reviewed Aug 3, 2024

View reviewed changes

beacon_chain/spec/payload_attestations.nim Outdated Show resolved Hide resolved

tersec reviewed Aug 3, 2024

View reviewed changes

beacon_chain/spec/payload_attestations.nim Show resolved Hide resolved

taxmeifyoucan mentioned this pull request Aug 5, 2024

week 8 dev update eth-protocol-fellows/cohort-five#312

Merged

tersec reviewed Aug 6, 2024

View reviewed changes

beacon_chain/spec/payload_attestations.nim Outdated Show resolved Hide resolved

tersec reviewed Aug 6, 2024

View reviewed changes

beacon_chain/spec/helpers.nim Outdated Show resolved Hide resolved

tersec reviewed Aug 6, 2024

View reviewed changes

beacon_chain/spec/helpers.nim Outdated Show resolved Hide resolved

tersec reviewed Aug 6, 2024

View reviewed changes

beacon_chain/spec/payload_attestations.nim Outdated Show resolved Hide resolved

tersec reviewed Aug 6, 2024

View reviewed changes

beacon_chain/spec/helpers.nim Show resolved Hide resolved

tersec reviewed Aug 6, 2024

View reviewed changes

beacon_chain/spec/helpers.nim Outdated Show resolved Hide resolved

Tomi-3-0 force-pushed the epbs branch from d815d22 to 2c5a230 Compare August 6, 2024 14:09

tersec reviewed Aug 7, 2024

View reviewed changes

beacon_chain/spec/payload_attestations.nim Outdated Show resolved Hide resolved

tersec reviewed Aug 7, 2024

View reviewed changes

tersec reviewed Aug 11, 2024

View reviewed changes

beacon_chain/spec/payload_attestations.nim Outdated Show resolved Hide resolved

tersec reviewed Aug 11, 2024

View reviewed changes

beacon_chain/spec/payload_attestations.nim Outdated Show resolved Hide resolved

tersec reviewed Aug 11, 2024

View reviewed changes

beacon_chain/spec/payload_attestations.nim Outdated Show resolved Hide resolved

tersec reviewed Aug 11, 2024

View reviewed changes

beacon_chain/spec/payload_attestations.nim Outdated Show resolved Hide resolved

tersec reviewed Aug 11, 2024

View reviewed changes

beacon_chain/spec/payload_attestations.nim Outdated Show resolved Hide resolved

get_ptc_assignment

8e3817c

Redidacove suggested changes Oct 6, 2024

View reviewed changes

adds execution requests

b77ca15

Redidacove suggested changes Oct 7, 2024

View reviewed changes

beacon_chain/spec/datatypes/epbs.nim Outdated Show resolved Hide resolved

Merge branch 'unstable' into epbs

5089ca5

tersec and others added 2 commits October 8, 2024 03:31

Update beacon_chain/spec/datatypes/epbs.nim

d7cdf43

Co-authored-by: Md Amaan <114795592+Redidacove@users.noreply.github.com>

removed code

71f9c20

Redidacove mentioned this pull request Oct 8, 2024

Execution Requests redefinition removed Tomi-3-0/nimbus-eth2#1

Merged

Merge pull request #1 from Tomi-3-0/remove_redundant_def

af91e67

Execution Requests redefinition removed

Tomi-3-0 added 4 commits October 8, 2024 20:47

test verify_execution_payload_header_signature

b480b7a

tests: verify payload attestaion and payload envelope signatures

2c80063

deleted executable file

235ccab

Merged remote epbs changes

eddf1ef

Sync vendor submodules with unstable branch

a8128d7

tersec reviewed Oct 14, 2024

View reviewed changes

Tomi-3-0 closed this Oct 14, 2024

Tomi-3-0 reopened this Oct 14, 2024

reapplied the .vscode/tasks.json

0c9b3db

Tomi-3-0 and others added 2 commits November 6, 2024 11:47

Resolved merge conflict in beacon_chain/spec/forks.nim

da0d6c2

Merge branch 'unstable' into epbs

90d5480

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] epbs (eip-7732) #6443

[WIP] epbs (eip-7732) #6443

Tomi-3-0 commented Jul 23, 2024

github-actions bot commented Jul 27, 2024 •

edited

Loading

tersec Aug 6, 2024

Tomi-3-0 Aug 6, 2024

tersec Aug 6, 2024

tersec commented Aug 6, 2024

Tomi-3-0 commented Aug 6, 2024

tersec Aug 7, 2024

tersec commented Aug 11, 2024

Redidacove Oct 6, 2024

Tomi-3-0 Oct 9, 2024

tersec commented Oct 8, 2024

Redidacove commented Oct 8, 2024 •

edited

Loading

tersec commented Oct 8, 2024

tersec commented Oct 9, 2024

Redidacove commented Oct 9, 2024

tersec commented Oct 9, 2024

tersec commented Oct 14, 2024

tersec Oct 14, 2024

Tomi-3-0 Oct 14, 2024

tersec commented Oct 14, 2024

Tomi-3-0 commented Oct 14, 2024

tersec commented Oct 16, 2024

		indexed_payload_attestation.signature)

		# # https://github.com/ethereum/consensus-specs/blob/1508f51b80df5488a515bfedf486f98435200e02/specs/_features/eipxxxx/beacon-chain.md#is_parent_block_full

	for slot in start_slot .. start_slot + SLOTS_PER_EPOCH - 1:
	for slot in start_slot .. <end_slot:

[WIP] epbs (eip-7732) #6443

Are you sure you want to change the base?

[WIP] epbs (eip-7732) #6443

Conversation

Tomi-3-0 commented Jul 23, 2024

github-actions bot commented Jul 27, 2024 • edited Loading

Unit Test Results

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tersec commented Aug 6, 2024

Tomi-3-0 commented Aug 6, 2024

Choose a reason for hiding this comment

tersec commented Aug 11, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tersec commented Oct 8, 2024

Redidacove commented Oct 8, 2024 • edited Loading

tersec commented Oct 8, 2024

tersec commented Oct 9, 2024

Redidacove commented Oct 9, 2024

tersec commented Oct 9, 2024

tersec commented Oct 14, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tersec commented Oct 14, 2024

Tomi-3-0 commented Oct 14, 2024

tersec commented Oct 16, 2024

github-actions bot commented Jul 27, 2024 •

edited

Loading

Redidacove commented Oct 8, 2024 •

edited

Loading