-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement getBlobs
and bypass blob gossip validation on successful blob retrievals from EL
#6913
base: unstable
Are you sure you want to change the base?
Conversation
for devnet testing locally, use |
beacon_chain/nimbus_beacon_node.nim
Outdated
when consensusFork >= ConsensusFork.Electra: | ||
# Pull blobs and proofs from the EL blob pool | ||
let blobsFromElOpt = await node.elManager.sendGetBlobs(forkyBlck) | ||
debugEcho "pulled blobs from el" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Obligatory comment about debugEcho
(but yeah, it's a draft PR and useful for now)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just for now, until i see things are ok in the local devnet
6ad1b3d
to
03e11ee
Compare
we're finalising with nimbus running |
we can get some better decision making on whether to validate blob gossip or pull blobs from EL every slot, by caching |
getBlobs
getBlobs
and bypass blob gossip validation on successful blob retrievals from EL
ethereum/execution-apis#559
if EL supports
engine_getBlobsV1
else
Note:
getBlobs
innimbus-eth2
here is made to be backward compatible from Electra and NOT Deneb (Deneb is what the spec suggests)Pros
Cons
RequestManager
should be able to fetch back the otherwise malicious blob/proof data sent by the bad EL, EL can be quickly swapped, Nimbus would rely on blob gossip that entire duration and switch back to optimistically pulling blobs from EL.CI failing: because of some nim-web3 upstream incompatibilities