cherry pick iOS signing to 2.36 #19635
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siddarthkay
requested review from
alaibe and
vkjr
and removed request for
a team
Member
Jenkins BuildsClick to see older builds (13)
|
siddarthkay
changed the title
jrainville
reviewed
Dec 24, 2025
Member
jrainville
left a comment
jrainville
left a comment
There was a problem hiding this comment.
Looks good, but the wallet changes seem to be accidental ports from the token refactor
Member
There was a problem hiding this comment.
All those wallet/token file changes can be discarded I think
Contributor
Author
There was a problem hiding this comment.
I removed those from my PR, sale forgot to clean some up in his PR
- points to `fix-ios-signing-with-fastlane` branch of `status-jenkins-lib` which provides development certs for PR builds and distribution certs for release builds. - adds nix flake to provide ruby dependencies for `fastlane` - adds config for new build identifier for PRs: `app.status.mobile.pr` - swaps testflight script with fastlane action - adds job to build iOS in release
siddarthkay
force-pushed
the
release-with-ios
branch
from
9a52199 to
c7aab4f
Compare
jrainville
approved these changes
Dec 24, 2025
Member
jrainville
left a comment
jrainville
left a comment
There was a problem hiding this comment.
So which PR should we merge? The wallet changes are not needed on release then?
Contributor
Author
|
@jrainville : if builds pass without them, they're not needed. so ideally this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick of : #19505