Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Balance tag background or add border as it not visible on whitebackground #14203

Closed
Tracked by #13399
Khushboo-dev-cpp opened this issue Mar 27, 2024 · 2 comments · Fixed by #14560
Closed
Tracked by #13399

Comments

@Khushboo-dev-cpp
Copy link
Contributor

Khushboo-dev-cpp commented Mar 27, 2024

image

currently the balances tag on erc1155 is not visible on white background , need to update this to make it more visible once @benjthayer finalises a solution for this.

also handle comment here #14204 (comment)

@benjthayer
Copy link

@Khushboo-dev-cpp as discussed, here are a series of screens which clarify how to handle collectibles of different aspect ratios which should ensure that the number tag is always visible. :)

https://www.figma.com/file/FkFClTCYKf83RJWoifWgoX/Wallet-v2?type=design&node-id=22617-232319&mode=design&t=L1UVvYZNThZGgwti-4

@Khushboo-dev-cpp
Copy link
Contributor Author

Only other thing to note is that ther 240 x 240 px that we use for the square aspect ratio collectible detail page image - those dimensions should be the max dimensions for the height / width of the image. 

I.e. if we have a horizontal aspect ratio image, the max width should be 240px (the height will be determined by how much the image needs to be resized)

If the image is portrait, then the max height should be 240px (and the width will be determined by how much the image needs to be resized)

Adding comment from Ben here

Khushboo-dev-cpp added a commit that referenced this issue Apr 29, 2024
… have min width and height in collectible details

Also make images zoom to cropped when visible in the collectibles list view

fixes #14203
Khushboo-dev-cpp added a commit that referenced this issue Apr 30, 2024
… have min width and height in collectible details

Also make images zoom to cropped when visible in the collectibles list view

fixes #14203
Khushboo-dev-cpp added a commit that referenced this issue Apr 30, 2024
… have min width and height in collectible details

Also make images zoom to cropped when visible in the collectibles list view

fixes #14203
Khushboo-dev-cpp added a commit that referenced this issue Apr 30, 2024
… have min width and height in collectible details

Also make images zoom to cropped when visible in the collectibles list view

fixes #14203
Khushboo-dev-cpp added a commit that referenced this issue Apr 30, 2024
… have min width and height in collectible details

Also make images zoom to cropped when visible in the collectibles list view

fixes #14203
Khushboo-dev-cpp added a commit that referenced this issue Apr 30, 2024
… have min width and height in collectible details

Also make images zoom to cropped when visible in the collectibles list view

fixes #14203
Khushboo-dev-cpp added a commit that referenced this issue May 6, 2024
… have min width and height in collectible details

Also make images zoom to cropped when visible in the collectibles list view

fixes #14203
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment