-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(wallet): displaying L1 gas cost in UI #14149
Conversation
Jenkins BuildsClick to see older builds (18)
|
Hey @saledjenic ! Sure I can can we create a follow up task for this? so that all questions from design also can be followed up there? |
@Khushboo-dev-cpp that would be great, let's sync with @alaibe first. |
eefcde4
to
b3c73c0
Compare
I'd suggest merge only status-go then @Khushboo-dev-cpp take over that PR? |
That's fine, since it won't break anything will do that once statusgo PR gets approved. |
97ff669
to
4d77feb
Compare
@Khushboo-dev-cpp an update for you, the status-go part is merged and updated here, this PR is ready for you to take it over. :) |
@benjthayer need your help on how to display L1 fees for transaction on Optimism in the fees section |
4d77feb
to
cde5a46
Compare
Created follow up task for design on how to show the L1 fees #14208 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
Corresponding
status-go
PR:Fixes #13892
@Khushboo-dev-cpp could you please help on this or take over from this point on?
I introduced L2 fee property on the status-go side and added it to the Fees component on the UI, but now I see a discrepancy between the values displayed in Fees section and fees displayed in the Send modal popup.
We also need a proper design for it.