Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(communities): when only keycard accounts selected (and 1 keycard) authentication is not triggered #14183

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

saledjenic
Copy link
Contributor

It's a single line change since values() on the map returns an iterator, and since I changed that line based on review comments in my previous PR it got broken. Fixed now.

Closes #14175

@status-im-auto
Copy link
Member

status-im-auto commented Mar 27, 2024

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ aeb05cb #1 2024-03-27 09:34:30 ~7 min macos/aarch64 🍎dmg
✔️ aeb05cb #1 2024-03-27 09:34:38 ~7 min tests/nim 📄log
✔️ aeb05cb #1 2024-03-27 09:38:16 ~10 min macos/x86_64 🍎dmg
✔️ aeb05cb #1 2024-03-27 09:38:23 ~10 min tests/ui 📄log
✔️ aeb05cb #1 2024-03-27 09:45:07 ~17 min linux/x86_64 📦tgz
✔️ aeb05cb #1 2024-03-27 09:55:38 ~28 min windows/x86_64 💿exe

@saledjenic saledjenic requested a review from caybro March 27, 2024 10:47
Copy link
Member

@caybro caybro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@noeliaSD noeliaSD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. It'd be nice if someone else with a keycard can test it. @alexjba ??

@saledjenic saledjenic merged commit 3e76fa6 into master Mar 28, 2024
8 checks passed
@saledjenic saledjenic deleted the fix/issue-14175 branch March 28, 2024 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants