Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(SendModal) missing icons for assets in Send Modal #14223

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

stefandunca
Copy link
Contributor

Closes: #14218

In case of assets the symbol doesn't have an icon representation in resources, hence we use the image of the asset itself. Same fix was applied for header and delegates

@status-im-auto
Copy link
Member

status-im-auto commented Mar 28, 2024

Jenkins Builds

Click to see older builds (6)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ b049b38 #1 2024-03-28 23:21:59 ~6 min tests/nim 📄log
✔️ b049b38 #1 2024-03-28 23:22:15 ~6 min macos/aarch64 🍎dmg
✔️ b049b38 #1 2024-03-28 23:26:05 ~10 min macos/x86_64 🍎dmg
✔️ b049b38 #1 2024-03-28 23:26:22 ~10 min tests/ui 📄log
✔️ b049b38 #1 2024-03-28 23:33:52 ~18 min linux/x86_64 📦tgz
✔️ b049b38 #1 2024-03-28 23:46:05 ~30 min windows/x86_64 💿exe
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ d686636 #2 2024-04-01 13:17:04 ~6 min tests/nim 📄log
✔️ d686636 #2 2024-04-01 13:17:30 ~6 min macos/aarch64 🍎dmg
✔️ d686636 #2 2024-04-01 13:19:33 ~8 min macos/x86_64 🍎dmg
✔️ d686636 #2 2024-04-01 13:21:43 ~11 min tests/ui 📄log
✔️ d686636 #2 2024-04-01 13:26:15 ~15 min linux/x86_64 📦tgz
✔️ d686636 #2 2024-04-01 13:39:30 ~28 min windows/x86_64 💿exe
✔️ 5f583b8 #4 2024-04-03 06:27:07 ~5 min tests/nim 📄log
✔️ 5f583b8 #4 2024-04-03 06:27:53 ~6 min macos/aarch64 🍎dmg
✔️ 5f583b8 #4 2024-04-03 06:31:33 ~10 min macos/x86_64 🍎dmg
✔️ 5f583b8 #4 2024-04-03 06:32:48 ~11 min tests/ui 📄log
✔️ 5f583b8 #4 2024-04-03 06:39:03 ~17 min linux/x86_64 📦tgz
✔️ 5f583b8 #4 2024-04-03 06:50:28 ~28 min windows/x86_64 💿exe

@stefandunca stefandunca force-pushed the fix_assets_icons-14218 branch from b049b38 to d686636 Compare April 1, 2024 13:10
Copy link
Member

@caybro caybro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just use Constants.tokenIcon() pls

@stefandunca stefandunca force-pushed the fix_assets_icons-14218 branch from d686636 to d452d8d Compare April 3, 2024 06:19
In case of assets the symbol doesn't have an icon representation
in resources, hence we use the image of the asset itself.
Same fix used for header and delegate

Closes: #14218
@stefandunca stefandunca force-pushed the fix_assets_icons-14218 branch from d452d8d to 5f583b8 Compare April 3, 2024 06:21
Copy link
Member

@caybro caybro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@stefandunca stefandunca merged commit f9782d6 into master Apr 3, 2024
8 checks passed
@stefandunca stefandunca deleted the fix_assets_icons-14218 branch April 3, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing assets icon in Send Modal
4 participants