Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(permissions): fix view and post permission overwritten by view perm #14237

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

jrainville
Copy link
Member

Fixes #14209

The fix is in status-go here status-im/status-go#5000

The changes in this are just clean ups

@status-im-auto
Copy link
Member

status-im-auto commented Mar 29, 2024

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 5c298d6 #1 2024-03-29 18:08:19 ~7 min tests/nim 📄log
✔️ 5c298d6 #1 2024-03-29 18:08:27 ~7 min macos/aarch64 🍎dmg
✔️ 5c298d6 #1 2024-03-29 18:11:42 ~10 min macos/x86_64 🍎dmg
✔️ 5c298d6 #1 2024-03-29 18:13:10 ~11 min tests/ui 📄log
✔️ 5c298d6 #1 2024-03-29 18:19:13 ~18 min linux/x86_64 📦tgz
✔️ 5c298d6 #1 2024-03-29 18:34:17 ~33 min windows/x86_64 💿exe
✔️ 7ba641f #2 2024-04-04 19:30:51 ~6 min tests/nim 📄log
✔️ 7ba641f #2 2024-04-04 19:31:11 ~7 min macos/aarch64 🍎dmg
✔️ 7ba641f #2 2024-04-04 19:33:03 ~9 min macos/x86_64 🍎dmg
✔️ 7ba641f #2 2024-04-04 19:35:27 ~11 min tests/ui 📄log
✔️ 7ba641f #2 2024-04-04 19:39:57 ~16 min linux/x86_64 📦tgz
✔️ 7ba641f #2 2024-04-04 19:57:39 ~33 min windows/x86_64 💿exe

@jrainville jrainville force-pushed the fix/view-and-post-superceded-by-view branch from 5c298d6 to 7ba641f Compare April 4, 2024 19:23
@jrainville
Copy link
Member Author

The e2e kinda failed because it failed to create the report, so I'll just force merge

@jrainville jrainville merged commit 8f5efc6 into master Apr 4, 2024
7 of 8 checks passed
@jrainville jrainville deleted the fix/view-and-post-superceded-by-view branch April 4, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"View and post" permission does not have priority on "view" permissions
5 participants