Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: supress UnreachableCode check in keycard_popup/controller.nim #14254

Merged

Conversation

igor-sirotin
Copy link
Contributor

Description

This suppresses these build warnings:

src/app/modules/shared_modules/keycard_popup/controller.nim(446, 27) template/generic instantiation of `serviceApplicable` from here
src/app/modules/shared_modules/keycard_popup/controller.nim(117, 3) Warning: unreachable code after 'return' statement or '{.noReturn.}' proc [UnreachableCode]
src/app/modules/shared_modules/keycard_popup/controller.nim(446, 27) template/generic instantiation of `serviceApplicable` from here
src/app/modules/shared_modules/keycard_popup/controller.nim(118, 3) Warning: unreachable code after 'return' statement or '{.noReturn.}' proc [UnreachableCode]
src/app/modules/shared_modules/keycard_popup/controller.nim(446, 27) template/generic instantiation of `serviceApplicable` from here
src/app/modules/shared_modules/keycard_popup/controller.nim(120, 3) Warning: unreachable code after 'return' statement or '{.noReturn.}' proc [UnreachableCode]
src/app/modules/shared_modules/keycard_popup/controller.nim(446, 27) template/generic instantiation of `serviceApplicable` from here
src/app/modules/shared_modules/keycard_popup/controller.nim(122, 3) Warning: unreachable code after 'return' statement or '{.noReturn.}' proc [UnreachableCode]
src/app/modules/shared_modules/keycard_popup/controller.nim(446, 27) template/generic instantiation of `serviceApplicable` from here
src/app/modules/shared_modules/keycard_popup/controller.nim(124, 3) Warning: unreachable code after 'return' statement or '{.noReturn.}' proc [UnreachableCode]
src/app/modules/shared_modules/keycard_popup/controller.nim(446, 27) template/generic instantiation of `serviceApplicable` from here
src/app/modules/shared_modules/keycard_popup/controller.nim(126, 3) Warning: unreachable code after 'return' statement or '{.noReturn.}' proc [UnreachableCode]
src/app/modules/shared_modules/keycard_popup/controller.nim(446, 27) template/generic instantiation of `serviceApplicable` from here
src/app/modules/shared_modules/keycard_popup/controller.nim(128, 3) Warning: unreachable code after 'return' statement or '{.noReturn.}' proc [UnreachableCode]
src/app/modules/shared_modules/keycard_popup/controller.nim(446, 27) template/generic instantiation of `serviceApplicable` from here
src/app/modules/shared_modules/keycard_popup/controller.nim(130, 9) Warning: unreachable code after 'return' statement or '{.noReturn.}' proc [UnreachableCode]

Couldn't find a good way to fix the warning. It's safe just to suppress it.

@status-im-auto
Copy link
Member

status-im-auto commented Apr 2, 2024

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ f433843 #1 2024-04-02 14:48:24 ~6 min tests/nim 📄log
✔️ f433843 #1 2024-04-02 14:49:28 ~7 min macos/aarch64 🍎dmg
✔️ f433843 #1 2024-04-02 14:53:32 ~11 min tests/ui 📄log
✔️ f433843 #1 2024-04-02 14:53:50 ~11 min macos/x86_64 🍎dmg
✔️ f433843 #1 2024-04-02 14:58:17 ~16 min linux/x86_64 📦tgz
✔️ f433843 #1 2024-04-02 15:18:09 ~36 min windows/x86_64 💿exe
✔️ f433843 #3 2024-04-02 16:04:48 ~11 min tests/ui 📄log
✔️ 8ff2017 #2 2024-04-03 12:20:14 ~6 min tests/nim 📄log
✔️ 8ff2017 #2 2024-04-03 12:23:29 ~9 min macos/x86_64 🍎dmg
✔️ 8ff2017 #2 2024-04-03 12:26:09 ~12 min macos/aarch64 🍎dmg
✔️ 8ff2017 #2 2024-04-03 12:29:02 ~15 min linux/x86_64 📦tgz
✔️ 8ff2017 #4 2024-04-03 12:29:05 ~15 min tests/ui 📄log
✔️ 8ff2017 #2 2024-04-03 12:45:47 ~32 min windows/x86_64 💿exe

@igor-sirotin igor-sirotin force-pushed the chore/hide-UnreachableCode-keycard-popup-warning branch from f433843 to 8ff2017 Compare April 3, 2024 12:13
@igor-sirotin igor-sirotin merged commit 3750b99 into master Apr 3, 2024
8 checks passed
@igor-sirotin igor-sirotin deleted the chore/hide-UnreachableCode-keycard-popup-warning branch April 3, 2024 13:47
@jrainville jrainville added this to the 2.29.0 Beta milestone Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants