-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(@desktop/communities): request to join btn fixes #14287
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (8)
|
✔️ status-desktop/prs/linux/x86_64/tests-nim/PR-14287#1 🔹 ~6 min 45 sec 🔹 cc3c383 🔹 📦 tests/nim package |
caybro
approved these changes
Apr 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice work!
>>> Error loading StoryBook page: QUrl("file:///home/jenkins/workspace/s_linux_x86_64_tests-ui_PR-14287/storybook/pages/JoinCommunityViewPage.qml")
Needs fixing
mprakhov
force-pushed
the
mp/issue-14179
branch
2 times, most recently
from
April 4, 2024 12:15
f542509
to
6591fa7
Compare
MishkaRogachev
approved these changes
Apr 4, 2024
jrainville
added a commit
that referenced
this pull request
May 8, 2024
jrainville
added a commit
that referenced
this pull request
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
fixes:
request to join
button state switchingCloses:
Membership request pending
state should be shown immediately after clickingShare your addresses to join
#14179Affected areas
Requests to join
Screenshot of functionality (including design for comparison)
Screen.Recording.2024-04-04.at.11.44.54.mov