feat(OnboardingLayout): Decompose into smaller, pure ui sub-flows #16977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (29)
|
micieslak
force-pushed
the
feat/issue-16947
branch
2 times, most recently
from
30c6aba to
c9f2283
Compare
caybro
force-pushed
the
feat/onboarding-rework-1
branch
from
cf9b44d to
fb2ac62
Compare
caybro
requested review from
Cuteivist and
virginiabalducci
and removed request for
a team
caybro
force-pushed
the
feat/issue-16947
branch
from
c9f2283 to
1c2f3bd
Compare
caybro
force-pushed
the
feat/onboarding-rework-1
branch
from
fb2ac62 to
bee801e
Compare
caybro
force-pushed
the
feat/issue-16947
branch
from
1c2f3bd to
3db7b1c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
Decomposes
OnboardingLayoutinto following elements:OnboardingFloworchestrating all on-boarding flows on the stackOnboardingStackViewwhich is specifically configuredStackViewfor handling all on-boarding flowsOnboardingLayoutitself integratingOboardingFlowwith stores andOnboardingStackViewMoreover
OnboardingFlowconsists of sub-flows:CreateNewProfileFlowKeycardCreateProfileFlowRecoveryPhraseCreateProfileFlowLoginBySyncingFlowLoginWithKeycardFlowUseRecoveryPhraseFlowFlows don't operate on own
StackView, which must be provided from outside. This allows to compose complex flows from smaller ones within oneStackView.Other:
backAvailableHintto indicate if back button should be available or not. It brings two benefits:KeycardEnterPinPageonboarding-rework-1broke them)Further work
primaryFlow/secondaryFlowenums should be replaced by one enum, probably can be kept in the QML fileflowtype exposed viaOnboardingFlow::finishis not collected in an elegant way. Maybe there is better option for that.Sync in progressshould be notified for some time even if the underlying operation was very quick (no matter if error or success). This gives the user the opportunity to familiarize themselves with the message and prevents from "blinking" when things happen quickly.timeoutIntervalis probably not needed inSyncProgressPageandKeycardAddKeyPairPage. It should be decided on the backend level what's the actual timeout.OnboardingLayoutbackAvailableHintas it's implicit way of communication between flows and provided stack viewlocalAppSettingsid used from outer scope, ideally whole settings handling should be externalizedCloses: #16947
Affected areas
OnboardingLayoutand related componentsArchitecture compliance
My PR is consistent with this document: Status Desktop Architecture Guide
Screenshot of functionality (including design for comparison)