Fix context menus not updating when blocking/unblocking or when getting a CR #16978
+36
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrainville
requested review from
richard-ramos,
a team,
iurimatias and
osmaczko
and removed request for
a team
jrainville
force-pushed
the
fix/block-user-update
branch
from
4ac3209 to
ee5a83f
Compare
Jenkins BuildsClick to see older builds (7)
|
jrainville
commented
Dec 17, 2024
| isContact, | ||
| trustStatus, | ||
| ) | ||
|
|
jrainville
requested review from
micieslak,
caybro and
alexjba
as code owners
jrainville
changed the title
jrainville
force-pushed
the
fix/block-user-update
branch
from
c386920 to
be285b3
Compare
caybro
reviewed
Dec 18, 2024
Here https://github.com/status-im/status-desktop/pull/16978/files#diff-7638828ebe375b5677d6a6832e1d28dce5ac5551923d8995eba39c9dc272d59fR154 |
osmaczko
approved these changes
Dec 18, 2024
caybro
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
Fixes #16948 and #16952
The problem was that we just didn't pass
isBlockedto theItem. So either it never worked or we broke it during the refactors.We also didn't have updates when the events were called in the main module.
Same thing for the
contactRequestAffected areas
Member list in the admin panel and on the right bar of a community.
Screenshot of functionality (including design for comparison)
Block/unblock:
block-unblock.webm
CR:
contact-request-context-menu.webm
Impact on end user
Fixes the issue of missing updates
How to test
Risk
Tick one:
Worst case, the issue still happens