fix: Optimize ContactsView & MembersTabPanel settings pages #16979
+1,024
−950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (62)
|
caybro
force-pushed
the
16612-settings-optimize-contactsview-settings-page
branch
2 times, most recently
from
d0e8549 to
dd6550f
Compare
caybro
changed the title
caybro
force-pushed
the
16612-settings-optimize-contactsview-settings-page
branch
from
dd6550f to
7a700b7
Compare
- fixup margins and padding according to latest Figma designs - make a difference between a disabled and inactive tab by using opacity - provide smooth color transitions - add a dedicated StoryBook page
caybro
force-pushed
the
16612-settings-optimize-contactsview-settings-page
branch
2 times, most recently
from
285991f to
03f9af4
Compare
caybro
requested review from
Khushboo-dev-cpp,
virginiabalducci,
jrainville and
anastasiyaig
and removed request for
a team,
virginiabalducci and
Khushboo-dev-cpp
|
I did some quick tests on the Status Community. The performance looks fine. The only issue I found is that the Banned list is empty I tried master and it works fine, so there is a small broken thing there |
caybro
force-pushed
the
16612-settings-optimize-contactsview-settings-page
branch
from
03f9af4 to
55747bf
Compare
Ah great, good spot! Wrong enum, fixed :) |
|
@caybro i will fix the tests, looking into that now. Just one question: was the second checkbox changed to be not a checkbox on purpose?
|
Oh definitely not and I have no idea what happened here, will check |
- fix a bug where the Switch would start animating if it'd been checked on creation - add the same property `leftSide` to StatusSwitch (just like StatusCheckBox), and use `LayoutMirroring` to perform the visual inversion - fixup margins and padding, removing hardcoded values, according to latest Figma designs - make a difference between a disabled and inactive button by using opacity - provide smooth color transitions - add dedicated StoryBook pages
caybro
force-pushed
the
16612-settings-optimize-contactsview-settings-page
branch
from
55747bf to
2052cd3
Compare
And fixed :) |
- removed nested ListViews inside StackLayouts, in order to reduce the memory footprint and improve performance, and also to be able to better manage the scrolling - no more unrolled multiple listviews, which again hurt the performance; now the views instantiate the delegates dynamically on the fly - the tab bar and the search fields now stick to the top of the page, with the users list view scrolling independently - both views now uniformly use the common `ContactListItemDelegate` - the received/sent CRs are now combined into one `pendingContacts` model - factored out common search/filter criteria into a new, separate SFPM `UserFilterContainer` component - fix an issue where StatusContactVerificationIcons wasn't properly displaying the "blocked" state/icon - fix documentation comments, removed relative imports, and updated some Fixes #16612 Fixes #16958
caybro
force-pushed
the
16612-settings-optimize-contactsview-settings-page
branch
from
2052cd3 to
77975e9
Compare
anastasiyaig
force-pushed
the
16612-settings-optimize-contactsview-settings-page
branch
from
fe50257 to
6c476aa
Compare
anastasiyaig
force-pushed
the
16612-settings-optimize-contactsview-settings-page
branch
from
6c476aa to
3393297
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tip
Best review commit by commit; the first 2 contain UI components updates. Also, a lot of the new stuff is Storybook pages :)
What does the PR do
ContactListItemDelegatependingContactsmodelUserFilterContainercomponentFixes #16612
Fixes #16958
Affected areas
Settings/Contacts; Community/Settings/Members
Architecture compliance
My PR is consistent with this document: Status Desktop Architecture Guide
Screenshot of functionality (including design for comparison)
Contacts:
Community members:
