feat(@desktop/wallet): Create a new send module to clear out old logic and switch the old one to the new one later, once the old sendModal is not used anymore #16986
+1,292
−65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (14)
|
Khushboo-dev-cpp
force-pushed
the
feat/buildingSimpleSend
branch
from
8c89690 to
e0a6422
Compare
Khushboo-dev-cpp
force-pushed
the
feat/16919
branch
2 times, most recently
from
c883d39 to
77368f4
Compare
Khushboo-dev-cpp
requested review from
micieslak,
a team,
caybro and
alexjba
as code owners
Khushboo-dev-cpp
requested review from
Cuteivist
and removed request for
a team
Khushboo-dev-cpp
changed the title
Khushboo-dev-cpp
force-pushed
the
feat/buildingSimpleSend
branch
3 times, most recently
from
b6919a3 to
a40b6e6
Compare
…c and switch the old one to the new one later, once the old sendModal is not used anymore fixes #16919
Khushboo-dev-cpp
force-pushed
the
feat/16919
branch
from
77368f4 to
cb09738
Compare
caybro
reviewed
Jan 2, 2025
| /** input property to set estimated time **/ | ||
| property string estimatedTime | ||
| /** input property to set estimated fees in fiat **/ | ||
| property string estimatedFiatFees | ||
| /** input property to set estimated fees in crypto **/ | ||
| property string estimatedCryptoFees | ||
|
|
||
| /** property to set currently selected send type **/ | ||
| property string sendType: Constants.SendType.Transfer |
There was a problem hiding this comment.
Suggested change
| property string sendType: Constants.SendType.Transfer | |
| property int sendType: Constants.SendType.Transfer |
It's an int on Constants
| @@ -120,6 +123,17 @@ StatusDialog { | |||
| /** Output signal to inform that the forms been updated **/ | |||
| signal formChanged() | |||
|
|
|||
| /** function exposed to check if the form is filled correctly **/ | |||
| function allValuesFilledCorrectly() { | |||
| - key [string] - unique identifier of an asset | ||
| - decimals [int] - decimals of the token | ||
| - marketDetails [QObject] - collectible's contract address | ||
| - currencyPrice [CurrenctAmount] - assets market price in CurrencyAmount |
There was a problem hiding this comment.
Suggested change
| - currencyPrice [CurrenctAmount] - assets market price in CurrencyAmount | |
| - currencyPrice [CurrencyAmount] - assets market price in CurrencyAmount |
| currentCurrency: root.currentCurrency | ||
| fnFormatCurrencyAmount: root.fnFormatCurrencyAmount | ||
| fnResolveENS: root.fnResolveENS | ||
| fnResolveENS: root.fnResolveENS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #16919
What does the PR do
Connects the Simple Send to backend.
Created new send module which removed all handling of UI states on the nim side
Uses the new format of router from go side, instead of the old one
Remaining:
Affected areas
SimpleSendModal
Architecture compliance
My PR is consistent with this document: Status Desktop Architecture Guide
Screenshot of functionality (including design for comparison)
Screen.Recording.2024-12-19.at.11.56.56.PM.mov