feat(onbaording): implement basic functions for the new onboarding #17003
Conversation
Fixes #16832 Implements all the needed basic Nim functions for the new onboarding. They do no do anything just yet. They shall be integrated in another commit.
jrainville
requested review from
micieslak,
caybro,
alexjba and
a team
as code owners
jrainville
changed the title
Jenkins Builds
|
| proc createAccountAndLogin*(self: Controller, password: string): string = | ||
| return self.accountsService.createAccountAndLogin( | ||
| password, | ||
| displayName = "", |
There was a problem hiding this comment.
Don't we want to still generate at least some displayName?
There was a problem hiding this comment.
Good question. I haven't tested yet since I've yet to integrate it. I imagine that if we set it to "", it will automatically default to the alias, which should be what we want.
I think for now the alias is the three word name, but we were already thinking of replacing it for the pubkey, and it's an easy change
| mnemonic, | ||
| password, | ||
| recoverAccount, | ||
| displayName = "", |
| CreateProfileWithKeycardExistingSeedphrase, | ||
| LoginWithSeedphrase, | ||
| LoginWithSyncing, | ||
| LoginWithKeycard |
There was a problem hiding this comment.
My idea was to use the C++ enum here as the only source of truth (which I created in the other PR which is not merged yet ofc), and also in QML. Perhaps later :)
There was a problem hiding this comment.
Ah yeah. I didn't find an enum that was usable, so I created one, but I have nothing against getting rid of this one to share the same you have once I integrate.
Do you know how to access the enum from Nim?
| QtProperty[int] keycardRemainingPinAttempts: | ||
| read = getKeycardRemainingPinAttempts | ||
| notify = keycardRemainingPinAttemptsChanged | ||
| proc setKeycardRemainingPinAttempts(self: View, keycardRemainingPinAttempts: int) = |
There was a problem hiding this comment.
This should probably not have a setter?
There was a problem hiding this comment.
(same for some of the other props in this file too)
Fixes #16832
Implements all the needed basic Nim functions for the new onboarding.
They do no do anything just yet. They shall be integrated in another PR.
Everything compiles nonetheless.