Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wallet): Update send modal height handling #17143

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Cuteivist
Copy link
Contributor

What does the PR do

Update simple send modal height and recipient view behavior according to designs

Affected areas

Simple send modal

Architecture compliance

Screenshot of functionality (including design for comparison)

send_modal_height.mov

@status-im-auto
Copy link
Member

status-im-auto commented Jan 29, 2025

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 122d590 #1 2025-01-29 06:37:01 ~9 min tests/nim 📄log
✔️ 122d590 #1 2025-01-29 06:40:44 ~12 min tests/ui 📄log
✔️ 122d590 #1 2025-01-29 06:43:17 ~15 min macos/x86_64 🍎dmg
✔️ 122d590 #1 2025-01-29 06:45:28 ~17 min linux-nix/x86_64 📦tgz
✔️ 122d590 #1 2025-01-29 06:46:16 ~18 min linux/x86_64 📦tgz
✔️ 122d590 #1 2025-01-29 06:54:27 ~26 min windows/x86_64 💿exe
122d590 #1 2025-01-29 08:14:57 ~1 hr 46 min macos/aarch64 📄log
✔️ 122d590 #2 2025-01-29 18:25:43 ~5 min macos/aarch64 🍎dmg

@Khushboo-dev-cpp
Copy link
Contributor

@Cuteivist this solves the changing recipient panel height, but now the saved address has more height than it should

Screen.Recording.2025-01-30.at.10.44.46.mov

See here, the max height should be max height of the list that contains most elements which is resents in this case.
The modal should not occupy complete screen height.

Copy link
Contributor

@Khushboo-dev-cpp Khushboo-dev-cpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@Cuteivist
Copy link
Contributor Author

@Cuteivist this solves the changing recipient panel height, but now the saved address has more height than it should

Screen.Recording.2025-01-30.at.10.44.46.mov
See here, the max height should be max height of the list that contains most elements which is resents in this case. The modal should not occupy complete screen height.

NOTE: This was resolved in private chat. This behavior is expected by design.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants