Add Commands #1731

cammellos · 2019-12-13T08:37:09Z

This commit adds handling of Transaction commands.

It includes some changes for V1:

Handling contact updates
Handling sync installation

status-github-bot · 2019-12-13T08:37:15Z

Pull Request Checklist

Have you updated the documentation, if impacted (e.g. docs.status.im)?

status-im-auto · 2019-12-13T08:38:18Z

Jenkins Builds

Click to see older builds (117)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`d34166d`	#1	2019-12-13 08:38:17	~57 sec	`linux`	📦`zip`
✔️	`d34166d`	#1	2019-12-13 08:42:56	~5 min	`ios`	📦`zip`
✔️	`d34166d`	#1	2019-12-13 08:44:01	~6 min	`android`	📦`aar`

✔️	`91dcb32`	#2	2019-12-14 11:55:46	~3 min	`linux`	📦`zip`
✔️	`91dcb32`	#2	2019-12-14 12:05:01	~12 min	`ios`	📦`zip`
✔️	`91dcb32`	#2	2019-12-14 12:06:57	~14 min	`android`	📦`aar`

✔️	`cb3cae7`	#3	2019-12-16 17:35:54	~46 sec	`linux`	📦`zip`
✔️	`cb3cae7`	#3	2019-12-16 17:38:50	~3 min	`ios`	📦`zip`
✔️	`cb3cae7`	#3	2019-12-16 17:41:00	~5 min	`android`	📦`aar`

✔️	`e0cab12`	#4	2019-12-18 07:33:21	~49 sec	`linux`	📦`zip`
✔️	`e0cab12`	#4	2019-12-18 07:35:25	~2 min	`ios`	📦`zip`
✔️	`e0cab12`	#4	2019-12-18 07:38:17	~5 min	`android`	📦`aar`

✔️	`70a176b`	#5	2019-12-18 09:29:12	~44 sec	`linux`	📦`zip`
✔️	`70a176b`	#5	2019-12-18 09:33:56	~5 min	`ios`	📦`zip`
✔️	`70a176b`	#5	2019-12-18 09:34:21	~5 min	`android`	📦`aar`

✔️	`307941e`	#6	2019-12-18 11:20:01	~34 sec	`linux`	📦`zip`
✔️	`307941e`	#6	2019-12-18 11:22:20	~2 min	`ios`	📦`zip`
✔️	`307941e`	#6	2019-12-18 11:25:49	~6 min	`android`	📦`aar`

❌	`87de77d`	#7	2019-12-20 11:19:15	~29 sec	`ios`	📄`log`
✔️	`87de77d`	#7	2019-12-20 11:19:39	~52 sec	`linux`	📦`zip`
❌	`87de77d`	#7	2019-12-20 11:20:24	~1 min	`android`	📄`log`

✔️	`23703a7`	#8	2019-12-20 11:30:43	~37 sec	`linux`	📦`zip`
✔️	`23703a7`	#8	2019-12-20 11:33:00	~2 min	`ios`	📦`zip`
✔️	`23703a7`	#8	2019-12-20 11:36:21	~6 min	`android`	📦`aar`

✔️	`0c1f8cb`	#9	2019-12-20 13:00:27	~44 sec	`linux`	📦`zip`
✔️	`0c1f8cb`	#9	2019-12-20 13:02:32	~2 min	`ios`	📦`zip`
✔️	`0c1f8cb`	#9	2019-12-20 13:05:38	~5 min	`android`	📦`aar`

✔️	`72c2a91`	#10	2019-12-20 13:45:26	~32 sec	`linux`	📦`zip`
✔️	`72c2a91`	#10	2019-12-20 13:47:25	~2 min	`ios`	📦`zip`
✔️	`72c2a91`	#10	2019-12-20 13:50:44	~5 min	`android`	📦`aar`

✔️	`ad6b9ad`	#11	2019-12-20 14:56:46	~2 min	`linux`	📦`zip`
✔️	`ad6b9ad`	#11	2019-12-20 14:59:05	~4 min	`ios`	📦`zip`
✔️	`ad6b9ad`	#11	2019-12-20 15:03:51	~9 min	`android`	📦`aar`

❌	`e8d0a42`	#12	2019-12-20 17:03:45	~26 sec	`ios`	📄`log`
✔️	`e8d0a42`	#12	2019-12-20 17:03:52	~33 sec	`linux`	📦`zip`
❌	`e8d0a42`	#12	2019-12-20 17:04:51	~1 min	`android`	📄`log`

✔️	`262a79c`	#13	2019-12-20 17:26:12	~38 sec	`linux`	📦`zip`
✔️	`262a79c`	#13	2019-12-20 17:28:29	~2 min	`ios`	📦`zip`
✔️	`262a79c`	#13	2019-12-20 17:31:14	~5 min	`android`	📦`aar`

✔️	`9cdaf7f`	#14	2019-12-23 11:01:16	~44 sec	`linux`	📦`zip`
✔️	`9cdaf7f`	#14	2019-12-23 11:04:22	~3 min	`ios`	📦`zip`
✔️	`9cdaf7f`	#14	2019-12-23 11:06:05	~5 min	`android`	📦`aar`

✔️	`dc43abf`	#15	2019-12-23 11:45:57	~1 min	`linux`	📦`zip`
✔️	`dc43abf`	#15	2019-12-23 11:47:57	~3 min	`ios`	📦`zip`
✔️	`dc43abf`	#15	2019-12-23 11:50:32	~5 min	`android`	📦`aar`

✔️	`46573db`	#16	2019-12-23 11:50:29	~40 sec	`linux`	📦`zip`
✔️	`46573db`	#16	2019-12-23 11:52:34	~2 min	`ios`	📦`zip`
✔️	`46573db`	#16	2019-12-23 11:56:11	~5 min	`android`	📦`aar`

✔️	`07a80a2`	#17	2019-12-23 15:08:05	~45 sec	`linux`	📦`zip`
✔️	`07a80a2`	#17	2019-12-23 15:10:42	~3 min	`ios`	📦`zip`
✔️	`07a80a2`	#17	2019-12-23 15:12:58	~5 min	`android`	📦`aar`

✔️	`e577ae8`	#18	2019-12-23 15:35:17	~38 sec	`linux`	📦`zip`
✔️	`e577ae8`	#18	2019-12-23 15:37:26	~2 min	`ios`	📦`zip`
✔️	`e577ae8`	#18	2019-12-23 15:40:54	~6 min	`android`	📦`aar`

✔️	`fd97ec6`	#19	2019-12-23 16:59:50	~1 min	`linux`	📦`zip`
✔️	`fd97ec6`	#19	2019-12-23 17:01:28	~2 min	`ios`	📦`zip`
✔️	`fd97ec6`	#19	2019-12-23 17:04:33	~5 min	`android`	📦`aar`

✔️	`771ccb8`	#20	2019-12-23 17:35:52	~43 sec	`linux`	📦`zip`
✔️	`771ccb8`	#20	2019-12-23 17:37:50	~2 min	`ios`	📦`zip`
✔️	`771ccb8`	#20	2019-12-23 17:41:02	~5 min	`android`	📦`aar`

✔️	`e02de03`	#21	2019-12-23 19:03:11	~46 sec	`linux`	📦`zip`
✔️	`e02de03`	#21	2019-12-23 19:05:19	~2 min	`ios`	📦`zip`
✔️	`e02de03`	#21	2019-12-23 19:08:20	~5 min	`android`	📦`aar`

❌	`4854c0d`	#22	2019-12-30 13:42:16	~26 sec	`android`	📄`log`
✔️	`4854c0d`	#22	2019-12-30 13:42:41	~49 sec	`linux`	📦`zip`
✔️	`4854c0d`	#22	2019-12-30 13:47:27	~5 min	`ios`	📦`zip`

✔️	`85c3027`	#23	2019-12-30 15:15:19	~48 sec	`linux`	📦`zip`
✔️	`85c3027`	#23	2019-12-30 15:18:01	~3 min	`ios`	📦`zip`
✔️	`85c3027`	#23	2019-12-30 15:21:11	~6 min	`android`	📦`aar`

✔️	`b1d414d`	#24	2019-12-31 11:57:35	~45 sec	`linux`	📦`zip`
✔️	`b1d414d`	#24	2019-12-31 11:59:35	~2 min	`ios`	📦`zip`
✔️	`b1d414d`	#24	2019-12-31 12:02:39	~5 min	`android`	📦`aar`

✔️	`a9299af`	#25	2019-12-31 12:38:48	~44 sec	`linux`	📦`zip`
✔️	`a9299af`	#25	2019-12-31 12:40:51	~2 min	`ios`	📦`zip`
✔️	`a9299af`	#25	2019-12-31 12:44:14	~6 min	`android`	📦`aar`

✔️	`0464df2`	#26	2019-12-31 13:39:17	~53 sec	`linux`	📦`zip`
✔️	`0464df2`	#26	2019-12-31 13:41:04	~2 min	`ios`	📦`zip`
✔️	`0464df2`	#26	2019-12-31 13:44:01	~5 min	`android`	📦`aar`

✔️	`170d2d5`	#27	2019-12-31 14:43:11	~1 min	`linux`	📦`zip`
✔️	`170d2d5`	#27	2019-12-31 14:48:57	~6 min	`android`	📦`aar`
✔️	`170d2d5`	#27	2019-12-31 14:52:33	~10 min	`ios`	📦`zip`

✔️	`1f055c5`	#28	2020-01-02 10:41:42	~35 sec	`linux`	📦`zip`
✔️	`1f055c5`	#28	2020-01-02 10:44:14	~3 min	`ios`	📦`zip`
✔️	`1f055c5`	#28	2020-01-02 10:46:41	~5 min	`android`	📦`aar`

✔️	`5bb33f4`	#29	2020-01-02 11:23:12	~59 sec	`linux`	📦`zip`
✔️	`5bb33f4`	#29	2020-01-02 11:25:31	~3 min	`ios`	📦`zip`
✔️	`5bb33f4`	#29	2020-01-02 11:28:07	~5 min	`android`	📦`aar`

✔️	`67d8219`	#30	2020-01-03 11:29:29	~1 min	`linux`	📦`zip`
✔️	`67d8219`	#30	2020-01-03 11:31:43	~3 min	`ios`	📦`zip`
✔️	`67d8219`	#30	2020-01-03 11:34:30	~6 min	`android`	📦`aar`

✔️	`85c5f05`	#31	2020-01-03 11:30:08	~36 sec	`linux`	📦`zip`
✔️	`85c5f05`	#31	2020-01-03 11:34:46	~3 min	`ios`	📦`zip`
❌	`85c5f05`	#31	2020-01-03 11:34:55	~21 sec	`android`	📄`log`

❌	`5f86cf2`	#32	2020-01-07 10:32:56	~21 sec	`android`	📄`log`
✔️	`5f86cf2`	#32	2020-01-07 10:33:18	~41 sec	`linux`	📦`zip`
✔️	`5f86cf2`	#32	2020-01-07 10:35:45	~3 min	`ios`	📦`zip`

❌	`23fba03`	#33	2020-01-07 10:35:25	~16 sec	`android`	📄`log`
✔️	`23fba03`	#33	2020-01-07 10:35:57	~44 sec	`linux`	📦`zip`
✔️	`23fba03`	#33	2020-01-07 10:38:51	~3 min	`ios`	📦`zip`

❌	`346e105`	#34	2020-01-07 11:36:13	~18 sec	`android`	📄`log`
✔️	`346e105`	#34	2020-01-07 11:36:37	~40 sec	`linux`	📦`zip`
✔️	`346e105`	#34	2020-01-07 11:38:42	~2 min	`ios`	📦`zip`

✔️	`cb21670`	#35	2020-01-07 13:36:28	~1 min	`linux`	📦`zip`
✔️	`cb21670`	#35	2020-01-07 13:38:31	~3 min	`ios`	📦`zip`
✔️	`cb21670`	#35	2020-01-07 13:41:26	~6 min	`android`	📦`aar`

✔️	`8fe3564`	#36	2020-01-08 09:31:57	~47 sec	`linux`	📦`zip`
✔️	`8fe3564`	#36	2020-01-08 09:34:42	~3 min	`ios`	📦`zip`
✔️	`8fe3564`	#36	2020-01-08 09:37:04	~5 min	`android`	📦`aar`

✔️	`12c71db`	#37	2020-01-08 13:58:09	~44 sec	`linux`	📦`zip`
✔️	`12c71db`	#37	2020-01-08 14:00:35	~3 min	`ios`	📦`zip`
✔️	`12c71db`	#37	2020-01-08 14:03:19	~5 min	`android`	📦`aar`

❌	`93c1455`	#38	2020-01-10 08:25:31	~19 sec	`android`	📄`log`
✔️	`93c1455`	#38	2020-01-10 08:26:00	~45 sec	`linux`	📦`zip`
✔️	`93c1455`	#38	2020-01-10 08:28:20	~3 min	`ios`	📦`zip`

✔️	`dab54ba`	#39	2020-01-10 10:18:00	~43 sec	`linux`	📦`zip`
✔️	`dab54ba`	#39	2020-01-10 10:19:58	~2 min	`ios`	📦`zip`
✔️	`dab54ba`	#39	2020-01-10 10:23:35	~6 min	`android`	📦`aar`

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`dfc1077`	#40	2020-01-10 15:51:27	~1 min	`linux`	📦`zip`
✔️	`dfc1077`	#40	2020-01-10 15:53:27	~3 min	`ios`	📦`zip`
✔️	`dfc1077`	#40	2020-01-10 15:56:34	~6 min	`android`	📦`aar`

✔️	`9ebb134`	#41	2020-01-10 18:22:23	~55 sec	`linux`	📦`zip`
✔️	`9ebb134`	#41	2020-01-10 18:23:57	~2 min	`ios`	📦`zip`
✔️	`9ebb134`	#41	2020-01-10 18:27:25	~6 min	`android`	📦`aar`

eth-node/core/types/transaction.go

protocol/chat.go

protocol/go.mod

protocol/message_builder.go

protocol/message_validator.go

protocol/migrations/sqlite/000001_init.up.db.sql

adambabik · 2019-12-18T13:51:12Z

protocol/transaction_validator.go

+
+type TransactionValidator struct {
+	persistence *sqlitePersistence
+	addresses   map[string]bool


If checking only existence:

Suggested change

addresses map[string]bool

addresses map[string]struct{}

cammellos · 2020-01-07T12:15:10Z

@adambabik ready to be reviewed again, thanks!

protocol/message.go

protocol/message_processor.go

protocol/message_validator.go

protocol/messenger.go

cammellos · 2020-01-08T09:31:13Z

@adambabik ready for another round of review, thanks!

This commit adds handling of Transaction commands.

cammellos self-assigned this Dec 13, 2019

weekly-digest bot mentioned this pull request Dec 15, 2019

Weekly Digest (8 December, 2019 - 15 December, 2019) #1734

Closed

cammellos force-pushed the feature/commands branch 2 times, most recently from 70a176b to 307941e Compare December 18, 2019 11:19

adambabik reviewed Dec 18, 2019

View reviewed changes

cammellos mentioned this pull request Dec 18, 2019

New /send and /request flows to facilitate seamless token transfer status-im/status-mobile#9371

Closed

cammellos force-pushed the feature/commands branch 6 times, most recently from e8d0a42 to 262a79c Compare December 20, 2019 17:25

weekly-digest bot mentioned this pull request Dec 22, 2019

Weekly Digest (15 December, 2019 - 22 December, 2019) #1754

Closed

cammellos force-pushed the feature/commands branch 8 times, most recently from 771ccb8 to e02de03 Compare December 23, 2019 19:02

weekly-digest bot mentioned this pull request Dec 29, 2019

Weekly Digest (22 December, 2019 - 29 December, 2019) #1760

Closed

cammellos force-pushed the feature/commands branch 3 times, most recently from 67d8219 to 85c5f05 Compare January 3, 2020 11:29

weekly-digest bot mentioned this pull request Jan 5, 2020

Weekly Digest (29 December, 2019 - 5 January, 2020) #1765

Closed

cammellos force-pushed the feature/commands branch 2 times, most recently from 5f86cf2 to 23fba03 Compare January 7, 2020 10:35

cammellos force-pushed the feature/commands branch from 23fba03 to 346e105 Compare January 7, 2020 11:35

cammellos changed the title ~~[WIP] Add Commands~~ Add Commands Jan 7, 2020

cammellos force-pushed the feature/commands branch from 346e105 to e702337 Compare January 7, 2020 11:59

adambabik reviewed Jan 7, 2020

View reviewed changes

protocol/message.go Outdated Show resolved Hide resolved

cammellos force-pushed the feature/commands branch from e702337 to cb21670 Compare January 7, 2020 13:35

cammellos requested a review from pedropombeiro January 7, 2020 14:24

adambabik reviewed Jan 7, 2020

View reviewed changes

cammellos force-pushed the feature/commands branch from cb21670 to 8fe3564 Compare January 8, 2020 09:30

cammellos force-pushed the feature/commands branch from 8fe3564 to 12c71db Compare January 8, 2020 13:57

adambabik approved these changes Jan 9, 2020

View reviewed changes

cammellos force-pushed the feature/commands branch 4 times, most recently from dfc1077 to 9ebb134 Compare January 10, 2020 18:21

Add Commands

9ebb134

This commit adds handling of Transaction commands.

cammellos merged commit 88a1d01 into develop Jan 10, 2020

delete-merged-branch bot deleted the feature/commands branch January 10, 2020 18:59

weekly-digest bot mentioned this pull request Jan 12, 2020

Weekly Digest (5 January, 2020 - 12 January, 2020) #1786

Closed

0xc1c4da unassigned cammellos Apr 29, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Commands #1731

Add Commands #1731

cammellos commented Dec 13, 2019 •

edited by 0xc1c4da

Loading

status-github-bot bot commented Dec 13, 2019

status-im-auto commented Dec 13, 2019 •

edited

Loading

adambabik Dec 18, 2019

cammellos commented Jan 7, 2020

cammellos commented Jan 8, 2020

Add Commands #1731

Add Commands #1731

Conversation

cammellos commented Dec 13, 2019 • edited by 0xc1c4da Loading

status-github-bot bot commented Dec 13, 2019

Pull Request Checklist

status-im-auto commented Dec 13, 2019 • edited Loading

Jenkins Builds

adambabik Dec 18, 2019

Choose a reason for hiding this comment

cammellos commented Jan 7, 2020

cammellos commented Jan 8, 2020

cammellos commented Dec 13, 2019 •

edited by 0xc1c4da

Loading

status-im-auto commented Dec 13, 2019 •

edited

Loading