Put settings in a table with schema #1746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Checklist
|
Jenkins BuildsClick to see older builds (132)
|
yenda
force-pushed
the
feature/settings3
branch
from
2ae0b60
to
9a15602
Compare
corpetty
reviewed
Dec 19, 2019
corpetty
requested changes
Dec 19, 2019
There was a problem hiding this comment.
There is also the os.MkdirAll issue from the audit (https://github.com/status-im/trailofbits-audit/issues/41). Maybe this should be a diff PR, but fixing the file permissions in this one is a start in the right direction.
andremedeiros
approved these changes
Dec 19, 2019
andremedeiros
force-pushed
the
feature/settings3
branch
from
f284a79
to
2f040c2
Compare
yenda
changed the title
cammellos
reviewed
Dec 20, 2019
cammellos
suggested changes
Dec 20, 2019
|
@adambabik could you have a look? Ideally we'd want this branch to be merged today |
cammellos
approved these changes
Dec 20, 2019
|
@corpetty is your change still requested? |
yenda
force-pushed
the
feature/settings3
branch
from
cf556fc
to
3a81962
Compare
corpetty
approved these changes
Dec 20, 2019
yenda
force-pushed
the
feature/settings3
branch
from
36f2faa
to
90071b7
Compare
adambabik
reviewed
Dec 20, 2019
| ChaosMode bool `json:"chaos-mode?,omitempty"` | ||
| Currency string `json:"currency,omitempty"` | ||
| CurrentNetwork string `json:"networks/current-network"` | ||
| CustomBootnodes *json.RawMessage `json:"custom-boot-nodes,omitempty"` |
There was a problem hiding this comment.
json.RawMessage is alias of []byte so it's already a pointer because slices are pointers. json.RawMessage should be enough.
There was a problem hiding this comment.
it's because it's not just json.RawMessage it can also be nil, when calling getSettings if it's not a pointer you get:
Error: Received unexpected error:
sql: Scan error on column index 4, name "custom_bootnodes": unsupported Scan, storing driver.Value type <nil> into type *json.RawMessage
yenda
force-pushed
the
feature/settings3
branch
from
df7eb10
to
3d3cab8
Compare
This reverts commit e8d7149.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move settings table schema from a key-value store to a one row table with many columns.
We now save the first raw with initial data in saveAccountAndLogin and follow up saveSetting calls are only saving one setting at a time.