Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add missing jq checks, make formatting vars the same #1753

Merged
merged 1 commit into from
Dec 21, 2019
Merged

add missing jq checks, make formatting vars the same #1753

merged 1 commit into from
Dec 21, 2019

Conversation

jakubgs
Copy link
Member

@jakubgs jakubgs commented Dec 20, 2019 •
edited by 0xc1c4da
Loading

Changes:

  • Added checks for jq in gen_config.sh and Makefiles.
  • Used absolute path to config.json in service.template
  • Also streamlined naming of formatting variables.

@jakubgs
add missing jq checks, make formatting vars the same
dddedc5 
Signed-off-by: Jakub Sokołowski <jakub@status.im>
@jakubgs jakubgs added the devops label Dec 20, 2019
@jakubgs jakubgs self-assigned this Dec 20, 2019
@status-github-bot
Copy link

Pull Request Checklist

  • Have you updated the documentation, if impacted (e.g. docs.status.im)?

@jacqueswww
Copy link

LGTM

@status-im-auto
Copy link
Member

status-im-auto commented Dec 20, 2019 •
edited
Loading

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ dddedc5 #1 2019-12-20 13:14:32 ~1 min linux 📦zip
✔️ dddedc5 #1 2019-12-20 13:18:21 ~5 min ios 📦zip
✔️ dddedc5 #1 2019-12-20 13:22:32 ~9 min android 📦aar

@jakubgs jakubgs mentioned this pull request Dec 20, 2019
Closed
@jakubgs jakubgs merged commit ccf3cd5 into develop Dec 21, 2019
@delete-merged-branch delete-merged-branch bot deleted the improve-checks branch December 21, 2019 08:17
@weekly-digest weekly-digest bot mentioned this pull request Dec 22, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacqueswww jacqueswww jacqueswww approved these changes

@adambabik adambabik adambabik approved these changes

Assignees
No one assigned
Labels
devops
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jakubgs @jacqueswww @status-im-auto @adambabik