Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump version to 0.39.3 #1785

Closed
wants to merge 1 commit into from
Closed

bump version to 0.39.3 #1785

wants to merge 1 commit into from

Conversation

jakubgs
Copy link
Member

@jakubgs jakubgs commented Jan 11, 2020 •
edited by 0xc1c4da
Loading

I'm trying to fix the build issues with my changes #1073. I tried building with them but it fails with:

$ go get github.com/status-im/status-go@330d177de6554eee61a85d9eff7582c99fbbfcad
go: finding github.com 330d177de6554eee61a85d9eff7582c99fbbfcad
go: finding github.com/status-im/status-go 330d177de6554eee61a85d9eff7582c99fbbfcad
go: finding github.com/status-im 330d177de6554eee61a85d9eff7582c99fbbfcad
go: downloading github.com/status-im/status-go v0.39.3-0.20200111184124-330d177de655
go: extracting github.com/status-im/status-go v0.39.3-0.20200111184124-330d177de655
go get: github.com/status-im/status-go@v0.39.3-0.20200111184124-330d177de655 requires
github.com/status-im/status-go/protocol@v1.1.0 requires
github.com/gomarkdown/markdown@v0.0.0-20191209105822-e3ba6c6109ba: invalid version: unknown revision e3ba6c6109ba

I assume I have to update protocol and tag that with protocol/v1.1.1 but I tried that and it failed anyway. I found out that for some reason protocol depends on status-go and status-go depends on protocol:

status-go/go.mod

Line 41 in 330d177

github.com/status-im/status-go/protocol v1.1.0

status-go/protocol/go.mod

Line 26 in 330d177

github.com/status-im/status-go v0.38.5 // indirect

This creates some kind of weird loop. I really think we need to drop the whole submodules thing because it creates so many issues it's beyond retarded.

@jakubgs
bump version to 0.39.3
a726462 
Also:
- bump protocol v1.1.1
- remove status-go from protocol deps
- run make vendor

Signed-off-by: Jakub Sokołowski <jakub@status.im>
@jakubgs jakubgs self-assigned this Jan 11, 2020
@status-github-bot
Copy link

Pull Request Checklist

  • Have you updated the documentation, if impacted (e.g. docs.status.im)?

@status-im-auto
Copy link
Member

status-im-auto commented Jan 11, 2020 •
edited
Loading

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ a726462 #1 2020-01-11 19:30:11 ~46 sec linux 📦zip
✔️ a726462 #1 2020-01-11 19:34:48 ~5 min ios 📦zip
✔️ a726462 #1 2020-01-11 19:36:42 ~7 min android 📦aar

@jakubgs
Copy link
Member Author

jakubgs commented Jan 11, 2020

Also, I can't really find how exactly status-go/protocol uses status-go, it doesn't seem to.

@weekly-digest weekly-digest bot mentioned this pull request Jan 12, 2020
Closed
@adambabik
Copy link
Contributor

I run go mod why -m github.com/status-im/status-go in protocol/ and it does not need it. It is removed when run go mod tidy in protocol/.

At the same time, I agree that currently submodules cause more harm than good. I will prepare a PR which gets rid of them. We can always introduce them later.

@weekly-digest weekly-digest bot mentioned this pull request Feb 16, 2020
Closed
@adambabik
Copy link
Contributor

I believe this was solved.

@adambabik adambabik closed this Mar 4, 2020
@jakubgs jakubgs deleted the protocol-fix branch October 1, 2021 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adambabik adambabik Awaiting requested review from adambabik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jakubgs @status-im-auto @adambabik