Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement new endpoint to set customization color #4568

Merged
merged 5 commits into from
Feb 7, 2024
Merged

feat: implement new endpoint to set customization color #4568

merged 5 commits into from
Feb 7, 2024

Conversation

mohsen-ghafouri
Copy link
Contributor

new endpoint to set/change profile customization color

related to status-mobile issue status-im/status-mobile#18453

@mohsen-ghafouri mohsen-ghafouri self-assigned this Jan 15, 2024
@status-im-auto
Copy link
Member

status-im-auto commented Jan 15, 2024 •
edited
Loading

Jenkins Builds

Click to see older builds (66)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✖️ 5a4e30a #1 2024-01-15 22:29:06 ~2 min tests 📄log
✔️ 5a4e30a #1 2024-01-15 22:29:58 ~3 min linux 📦zip
✔️ 5a4e30a #1 2024-01-15 22:31:42 ~5 min ios 📦zip
✔️ 5a4e30a #1 2024-01-15 22:32:14 ~5 min android 📦aar
✖️ 025e357 #2 2024-01-16 04:04:15 ~1 min tests 📄log
✔️ 025e357 #2 2024-01-16 04:04:59 ~1 min android 📦aar
✔️ 025e357 #2 2024-01-16 04:06:23 ~3 min linux 📦zip
✔️ 025e357 #2 2024-01-16 04:06:35 ~3 min ios 📦zip
✖️ 43611aa #3 2024-01-16 15:13:35 ~3 min tests 📄log
✔️ 43611aa #3 2024-01-16 15:13:40 ~3 min linux 📦zip
✔️ 43611aa #3 2024-01-16 15:14:00 ~3 min ios 📦zip
✔️ 43611aa #3 2024-01-16 15:15:57 ~5 min android 📦aar
✔️ 2327cca #4 2024-01-16 22:49:22 ~1 min linux 📦zip
✔️ 2327cca #4 2024-01-16 22:49:47 ~2 min android 📦aar
✖️ 2327cca #4 2024-01-16 22:50:04 ~2 min tests 📄log
✔️ 2327cca #4 2024-01-16 22:51:11 ~3 min ios 📦zip
✖️ 97cfa26 #5 2024-01-18 08:26:49 ~1 min tests 📄log
✔️ 97cfa26 #5 2024-01-18 08:27:56 ~2 min android 📦aar
✔️ 97cfa26 #5 2024-01-18 08:29:14 ~3 min linux 📦zip
✔️ 97cfa26 #5 2024-01-18 08:30:00 ~4 min ios 📦zip
✔️ 2dc18bc #6 2024-01-18 13:16:59 ~1 min linux 📦zip
✔️ 2dc18bc #6 2024-01-18 13:17:27 ~2 min android 📦aar
✖️ 2dc18bc #6 2024-01-18 13:17:47 ~2 min tests 📄log
✔️ 2dc18bc #6 2024-01-18 13:20:32 ~5 min ios 📦zip
❌ 04da0b0 #7 2024-01-19 10:50:58 ~26 sec android 📄log
❌ 04da0b0 #7 2024-01-19 10:51:05 ~33 sec ios 📄log
❌ 04da0b0 #7 2024-01-19 10:51:45 ~1 min linux 📄log
✖️ 04da0b0 #7 2024-01-19 10:52:51 ~2 min tests 📄log
✖️ d1f6c04 #8 2024-01-19 11:50:25 ~2 min tests 📄log
✔️ d1f6c04 #8 2024-01-19 11:50:30 ~2 min linux 📦zip
✔️ d1f6c04 #8 2024-01-19 11:53:02 ~5 min ios 📦zip
✔️ d1f6c04 #8 2024-01-19 11:53:34 ~5 min android 📦aar
✖️ 4f575e9 #9 2024-01-19 14:19:11 ~1 min tests 📄log
✔️ 4f575e9 #9 2024-01-19 14:19:43 ~1 min linux 📦zip
✔️ 4f575e9 #9 2024-01-19 14:20:17 ~2 min android 📦aar
✔️ 4f575e9 #9 2024-01-19 14:21:16 ~3 min ios 📦zip
✖️ a954176 #10 2024-01-19 15:14:10 ~1 min tests 📄log
✔️ a954176 #10 2024-01-19 15:14:33 ~1 min linux 📦zip
✔️ a954176 #10 2024-01-19 15:17:12 ~4 min ios 📦zip
✔️ a954176 #10 2024-01-19 15:18:16 ~5 min android 📦aar
✖️ 0066f56 #11 2024-01-19 18:45:56 ~1 min tests 📄log
✔️ 0066f56 #11 2024-01-19 18:46:27 ~1 min linux 📦zip
✔️ 0066f56 #11 2024-01-19 18:46:51 ~2 min android 📦aar
✔️ 0066f56 #11 2024-01-19 18:52:31 ~7 min ios 📦zip
✖️ cebba65 #12 2024-01-19 19:01:23 ~1 min tests 📄log
✔️ cebba65 #12 2024-01-19 19:01:44 ~1 min linux 📦zip
✔️ cebba65 #12 2024-01-19 19:02:06 ~2 min android 📦aar
✔️ cebba65 #12 2024-01-19 19:07:24 ~7 min ios 📦zip
✔️ d57dee2 #13 2024-01-19 19:08:37 ~1 min linux 📦zip
✔️ d57dee2 #13 2024-01-19 19:09:14 ~2 min android 📦aar
✔️ d57dee2 #13 2024-01-19 19:14:31 ~7 min ios 📦zip
✖️ d57dee2 #13 2024-01-19 19:33:19 ~26 min tests 📄log
✖️ d57dee2 #14 2024-01-22 09:02:45 ~26 min tests 📄log
✔️ 13ab92f #14 2024-01-24 07:49:31 ~2 min android 📦aar
✔️ 13ab92f #14 2024-01-24 07:50:13 ~3 min linux 📦zip
✔️ 13ab92f #14 2024-01-24 07:50:14 ~3 min ios 📦zip
✖️ 13ab92f #15 2024-01-24 08:17:44 ~30 min tests 📄log
✔️ af7f5c4 #15 2024-01-29 10:41:53 ~3 min linux 📦zip
✔️ af7f5c4 #15 2024-01-29 10:42:31 ~3 min ios 📦zip
✔️ af7f5c4 #15 2024-01-29 10:43:49 ~5 min android 📦aar
✔️ af7f5c4 #19 2024-01-29 11:17:35 ~38 min tests 📄log
✔️ 3b9d813 #16 2024-02-05 09:17:20 ~3 min ios 📦zip
✔️ 3b9d813 #16 2024-02-05 09:17:27 ~3 min linux 📦zip
✔️ 3b9d813 #16 2024-02-05 09:18:12 ~4 min android 📦aar
✖️ 3b9d813 #20 2024-02-05 09:24:18 ~10 min tests 📄log
✔️ 3b9d813 #21 2024-02-05 12:07:31 ~40 min tests 📄log
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 3aa4361 #17 2024-02-07 12:59:57 ~2 min ios 📦zip
✔️ 3aa4361 #17 2024-02-07 13:00:06 ~3 min linux 📦zip
✔️ 3aa4361 #17 2024-02-07 13:01:23 ~4 min android 📦aar
✖️ 3aa4361 #22 2024-02-07 13:24:48 ~27 min tests 📄log
✔️ 78bcb72 #18 2024-02-07 14:39:00 ~3 min ios 📦zip
✔️ 78bcb72 #18 2024-02-07 14:42:34 ~7 min linux 📦zip
✔️ 78bcb72 #18 2024-02-07 14:44:27 ~8 min android 📦aar
✔️ 78bcb72 #23 2024-02-07 15:17:16 ~41 min tests 📄log

@mohsen-ghafouri mohsen-ghafouri force-pushed the feat/change-accent-colour branch from 5a4e30a to 025e357 Compare January 16, 2024 04:02
@mohsen-ghafouri mohsen-ghafouri force-pushed the feat/change-accent-colour branch 6 times, most recently from 04da0b0 to d1f6c04 Compare January 19, 2024 11:47
@mohsen-ghafouri mohsen-ghafouri marked this pull request as ready for review January 19, 2024 13:28
qfrank
qfrank reviewed Jan 19, 2024
View reviewed changes
protocol/messenger_settings.go Outdated Show resolved Hide resolved
protocol/requests/set_customization_color.go Show resolved Hide resolved
protocol/messenger_settings_test.go Show resolved Hide resolved
protocol/messenger_settings.go Show resolved Hide resolved
qfrank
qfrank approved these changes Jan 19, 2024
View reviewed changes
Copy link
Contributor

@qfrank qfrank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except additional minor comments

protocol/messenger_settings_test.go Show resolved Hide resolved
protocol/requests/set_customization_color.go Show resolved Hide resolved
@mohsen-ghafouri mohsen-ghafouri force-pushed the feat/change-accent-colour branch 5 times, most recently from d57dee2 to 13ab92f Compare January 24, 2024 07:46
@mohsen-ghafouri mohsen-ghafouri force-pushed the feat/change-accent-colour branch 2 times, most recently from af7f5c4 to 3b9d813 Compare February 5, 2024 09:13
@mohsen-ghafouri mohsen-ghafouri force-pushed the feat/change-accent-colour branch from 3b9d813 to 3aa4361 Compare February 7, 2024 12:56
@mohsen-ghafouri mohsen-ghafouri force-pushed the feat/change-accent-colour branch from 3aa4361 to 78bcb72 Compare February 7, 2024 14:35
@mohsen-ghafouri mohsen-ghafouri merged commit 70ee70a into develop Feb 7, 2024
7 checks passed
@mohsen-ghafouri mohsen-ghafouri deleted the feat/change-accent-colour branch February 7, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qfrank qfrank qfrank approved these changes

@cammellos cammellos Awaiting requested review from cammellos

@osmaczko osmaczko Awaiting requested review from osmaczko

Assignees

@mohsen-ghafouri mohsen-ghafouri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mohsen-ghafouri @status-im-auto @cammellos @qfrank