chore(config)_: rpc providers configuration #6151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (88)
|
friofry
force-pushed
the
ab/issue-5997-rpc-providers-configuration
branch
2 times, most recently
from
8195c81 to
099ebdf
Compare
friofry
changed the title
friofry
changed the title
friofry
force-pushed
the
ab/issue-5997-rpc-providers-configuration
branch
3 times, most recently
from
49c6278 to
0588310
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6151 +/- ##
===========================================
+ Coverage 61.44% 61.47% +0.02%
===========================================
Files 835 842 +7
Lines 110095 110595 +500
===========================================
+ Hits 67651 67991 +340
- Misses 34516 34623 +107
- Partials 7928 7981 +53
Flags with carried forward coverage won't be shown. Click here to find out more.
|
friofry
force-pushed
the
ab/issue-5997-rpc-providers-configuration
branch
from
0588310 to
50ee868
Compare
alaibe
approved these changes
Dec 11, 2024
Comment on lines
+43
to
+47
| if providers[i].Type == params.UserProviderType { | ||
| providers[i].Enabled = enabled | ||
| } else { | ||
| providers[i].Enabled = !enabled | ||
| } |
There was a problem hiding this comment.
Suggested change
| if providers[i].Type == params.UserProviderType { | |
| providers[i].Enabled = enabled | |
| } else { | |
| providers[i].Enabled = !enabled | |
| } | |
| providers[i].Enabled = enabled && (providers[i].Type == params.UserProviderType) |
There was a problem hiding this comment.
This is the equivalent form:
but I'm not sure it's any easier to understand
providers[i].Enabled = enabled == (providers[i].Type == params.UserProviderType)
There was a problem hiding this comment.
Indeed, my bad.
The == id definitely worse readable, so better to keep as you did then 👍
|
@friofry forgot to say: by the end of the review I was so annoyed of the size of the PR that I was tempting to reject it and ask to split in multiple... Looks like it was pretty possible to split it, there's good independency in the new code. |
friofry
force-pushed
the
ab/issue-5997-rpc-providers-configuration
branch
from
50ee868 to
1ecae6e
Compare
Sorry for the huge PR, I split it into 2 PRs (configuration + integration). Probably should have split it into more parts. |
friofry
force-pushed
the
ab/issue-5997-rpc-providers-configuration
branch
2 times, most recently
from
5df7c7e to
e04001a
Compare
1 task
igor-sirotin
approved these changes
Jan 8, 2025
friofry
force-pushed
the
ab/issue-5997-rpc-providers-configuration
branch
from
e04001a to
1c51d12
Compare
* Add rpc_providers table, migration * add RpcProvider type * deprecate old rpc fields in networks, add RpcProviders list * add persistence packages for rpc_providers, networks * Tests (without integration)
friofry
force-pushed
the
ab/issue-5997-rpc-providers-configuration
branch
from
1c51d12 to
c1b756f
Compare
friofry
requested review from
dlipicar,
Khushboo-dev-cpp and
saledjenic
and removed request for
dlipicar,
Khushboo-dev-cpp and
saledjenic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose to add some explicitness for:
->
This PR extracts
rpc_provider_persistencerpc_providerstable, migrationRpcProvidertype + validationThis PR does not change any existing functionality. The next PR will include integration of the new data structure: #6178
Closes #5997