Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat_: integrate base chain #6228

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

briansztamfater
Copy link
Member

This PR adds support for Base chain.

Closes #6224

@briansztamfater briansztamfater self-assigned this Dec 18, 2024
@briansztamfater briansztamfater force-pushed the feat/integrate-base-chain branch from 13d8a4e to b150dc8 Compare December 18, 2024 20:42
@status-im-auto
Copy link
Member

status-im-auto commented Dec 18, 2024

Jenkins Builds

Click to see older builds (16)
Commit #️⃣ Finished (UTC) Duration Platform Result
✖️ 13d8a4e #1 2024-12-18 20:44:01 ~3 min tests 📄log
✔️ 13d8a4e #1 2024-12-18 20:44:20 ~4 min macos 📦zip
✔️ 13d8a4e #1 2024-12-18 20:44:25 ~4 min ios 📦zip
✔️ 13d8a4e #1 2024-12-18 20:45:11 ~5 min linux 📦zip
✔️ 13d8a4e #1 2024-12-18 20:45:23 ~5 min macos 📦zip
✔️ 13d8a4e #1 2024-12-18 20:45:25 ~5 min android 📦aar
✔️ 13d8a4e #1 2024-12-18 20:46:05 ~5 min windows 📦zip
✔️ 13d8a4e #1 2024-12-18 20:47:00 ~6 min tests-rpc 📄log
✖️ b150dc8 #2 2024-12-18 20:46:40 ~2 min tests 📄log
✔️ b150dc8 #2 2024-12-18 20:48:06 ~3 min macos 📦zip
✔️ b150dc8 #2 2024-12-18 20:48:34 ~4 min ios 📦zip
✔️ b150dc8 #2 2024-12-18 20:50:20 ~5 min linux 📦zip
✔️ b150dc8 #2 2024-12-18 20:50:26 ~4 min windows 📦zip
✔️ b150dc8 #2 2024-12-18 20:50:45 ~5 min macos 📦zip
✔️ b150dc8 #2 2024-12-18 20:50:47 ~5 min android 📦aar
✔️ b150dc8 #2 2024-12-18 20:53:00 ~5 min tests-rpc 📄log
Commit #️⃣ Finished (UTC) Duration Platform Result
✖️ de357fc #3 2024-12-18 20:56:56 ~2 min tests 📄log
✔️ de357fc #3 2024-12-18 20:58:13 ~3 min macos 📦zip
✔️ de357fc #3 2024-12-18 20:58:41 ~4 min ios 📦zip
✔️ de357fc #3 2024-12-18 20:58:42 ~4 min windows 📦zip
✔️ de357fc #3 2024-12-18 20:59:42 ~5 min linux 📦zip
✔️ de357fc #3 2024-12-18 20:59:52 ~5 min android 📦aar
✔️ de357fc #3 2024-12-18 20:59:58 ~5 min macos 📦zip
✔️ de357fc #3 2024-12-18 21:01:05 ~6 min tests-rpc 📄log
✖️ eff4135 #4 2024-12-18 21:11:55 ~3 min tests 📄log
✔️ eff4135 #4 2024-12-18 21:12:07 ~4 min macos 📦zip
✔️ eff4135 #4 2024-12-18 21:12:16 ~4 min ios 📦zip
✔️ eff4135 #4 2024-12-18 21:12:16 ~4 min windows 📦zip
✔️ eff4135 #4 2024-12-18 21:13:01 ~4 min linux 📦zip
✔️ eff4135 #4 2024-12-18 21:13:25 ~5 min macos 📦zip
✔️ eff4135 #4 2024-12-18 21:13:26 ~5 min android 📦aar
✔️ eff4135 #4 2024-12-18 21:14:08 ~5 min tests-rpc 📄log

@briansztamfater briansztamfater force-pushed the feat/integrate-base-chain branch from b150dc8 to de357fc Compare December 18, 2024 20:54
Signed-off-by: Brian Sztamfater <brian@status.im>
@briansztamfater briansztamfater force-pushed the feat/integrate-base-chain branch from de357fc to eff4135 Compare December 18, 2024 21:07
@briansztamfater briansztamfater changed the title [WIP] feat_: integrate base chain feat_: integrate base chain Dec 18, 2024
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 54.78261% with 52 lines in your changes missing coverage. Please review.

Project coverage is 19.74%. Comparing base (d291204) to head (eff4135).

Files with missing lines Patch % Lines
...allet/router/pathprocessor/processor_bridge_hop.go 0.00% 22 Missing ⚠️
api/defaults.go 0.00% 4 Missing and 2 partials ⚠️
services/wallet/thirdparty/mercuryo/types.go 0.00% 4 Missing ⚠️
services/wallet/thirdparty/opensea/types_v2.go 0.00% 4 Missing ⚠️
services/wallet/router/common.go 0.00% 2 Missing ⚠️
...et/router/pathprocessor/processor_swap_paraswap.go 0.00% 2 Missing ⚠️
services/wallet/router/router_updates.go 0.00% 2 Missing ⚠️
services/wallet/thirdparty/alchemy/client.go 50.00% 2 Missing ⚠️
services/wallet/transfer/commands.go 0.00% 2 Missing ⚠️
services/wallet/activity/activity.go 0.00% 1 Missing ⚠️
... and 5 more

❗ There is a different number of reports uploaded between BASE (d291204) and HEAD (eff4135). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (d291204) HEAD (eff4135)
unit 1 0
Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #6228       +/-   ##
============================================
- Coverage    61.44%   19.74%   -41.71%     
============================================
  Files          834      812       -22     
  Lines       109919   132180    +22261     
============================================
- Hits         67543    26102    -41441     
- Misses       34490   103025    +68535     
+ Partials      7886     3053     -4833     
Flag Coverage Δ
functional 19.74% <54.78%> (-0.94%) ⬇️
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
api/default_networks.go 93.92% <100.00%> (-6.08%) ⬇️
mobile/callog/status_request_log.go 40.00% <ø> (-47.35%) ⬇️
protocol/requests/create_account.go 21.05% <ø> (-12.29%) ⬇️
services/wallet/onramp/provider_moonpay.go 75.86% <100.00%> (-0.14%) ⬇️
services/wallet/onramp/provider_ramp.go 75.86% <100.00%> (-0.14%) ⬇️
services/wallet/router/sendtype/send_type.go 46.25% <100.00%> (-10.00%) ⬇️
services/wallet/token/tokenstore.go 99.88% <100.00%> (-0.12%) ⬇️
services/wallet/activity/activity.go 9.00% <0.00%> (-77.85%) ⬇️
services/wallet/common/const.go 76.66% <75.00%> (-12.23%) ⬇️
services/wallet/onramp/provider_mercuryo.go 0.00% <0.00%> (-6.18%) ⬇️
... and 12 more

... and 765 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Wallet] Add support for Base chain
2 participants