ci_: upgrade go to 1.22 #6258
Open
ci_: upgrade go to 1.22 #6258
+123
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (87)
|
siddarthkay
force-pushed
the
bump-go-to-1-23
branch
3 times, most recently
from
f95fafe to
c74ebd3
Compare
|
My initial assumptions were that this failure happens due to a symlink issue in xcode wrapper nix derivation : Needs more investigation. This issue surfaces in |
siddarthkay
force-pushed
the
bump-go-to-1-23
branch
from
c74ebd3 to
2d2d927
Compare
siddarthkay
force-pushed
the
bump-go-to-1-23
branch
from
2d2d927 to
dd262fa
Compare
siddarthkay
force-pushed
the
bump-go-to-1-23
branch
3 times, most recently
from
b273909 to
58e0a24
Compare
igor-sirotin
approved these changes
Jan 16, 2025
I first tried with 1.23, there were many issues, I tried to outline the recommended steps here #6254 (comment) |
siddarthkay
force-pushed
the
bump-go-to-1-23
branch
from
58e0a24 to
7372d20
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6258 +/- ##
===========================================
- Coverage 61.92% 61.05% -0.88%
===========================================
Files 843 862 +19
Lines 111286 112696 +1410
===========================================
- Hits 68918 68801 -117
- Misses 34388 35921 +1533
+ Partials 7980 7974 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This was referenced Jan 16, 2025
jakubgs
approved these changes
Jan 16, 2025
yakimant
approved these changes
Jan 21, 2025
| }) | ||
| ]; | ||
| })); | ||
| gomobile = callPackage ./pkgs/gomobile { }; |
There was a problem hiding this comment.
Add a comment, why it is needed.
There was a problem hiding this comment.
Also, is it just a copy from certain commit (add which one) or some lines were edited (add comments, which ones and why)?
There was a problem hiding this comment.
Thanks! I will update comments.
Here i was updating to a newer version of gomobile and using latest derivation from master of nixpkgs.
siddarthkay
force-pushed
the
bump-go-to-1-23
branch
from
7372d20 to
87151d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6254
Summary
goto1.22xcodewrapperto latest version fromnixpkgsgomobilederivation with newer version.1.59.1forgoversion1.22support https://github.com/golangci/golangci-lint/releases/tag/v1.59.1gosecPending
Related
GO111MODULE=offworkaround golang/go#67927